Tue 02 Jun 2015 04:39:33 PM UTC, comment #27:
Retagging release from 4.0.0-rc1 to 4.0.0.
|
Wed 18 Mar 2015 10:32:35 AM UTC, comment #26:
Marking as fixed and closing
|
Wed 18 Mar 2015 08:10:21 AM UTC, comment #25:
Works for me to.
|
Wed 18 Mar 2015 02:40:39 AM UTC, comment #24:
Works for me.
|
Wed 18 Mar 2015 02:31:03 AM UTC, comment #23:
Pushed http://hg.savannah.gnu.org/hgweb/octave/rev/028b2302f940
|
Wed 18 Mar 2015 01:56:05 AM UTC, comment #22:
Testing changes now
|
Wed 18 Mar 2015 12:29:46 AM UTC, comment #21:
OK, so it is always supposed to return a column vector regardless of the size of the prompts? Do you want to combine the changes or should I?
Thanks.
|
Tue 17 Mar 2015 04:10:30 PM UTC, comment #20:
That's better for the input.
The output answer is incorrect still for the GUI link.
Octave:
Matlab
|
Tue 17 Mar 2015 03:32:32 PM UTC, comment #19:
Hmm, and I think we just need a change in inputdlg.m. See the attached change. It seems to work for me, but maybe I have it wrong.
(file #33379)
|
Tue 17 Mar 2015 03:27:39 PM UTC, comment #18:
New patch
Also occurs in Linux as well as Windows, so changing OS to any.
(file #33378)
|
Tue 17 Mar 2015 03:13:33 PM UTC, comment #17:
Looks like 2 issues occurring.
1) inputdlg.m is expected columns when it does things like: rowscols = zeros (columns (prompt), 2);
2) _octave_link_input_dialog_ returns the 1xX array and should be the Xx1.
So I will change inputdlg to make it columns always and fix (1 and modify octave-link.cc to fix (2.
|
Tue 17 Mar 2015 03:06:45 PM UTC, comment #16:
Yes I think was copy/paste and had done a=a(:)'; before the copy of the result.
|
Tue 17 Mar 2015 02:50:08 PM UTC, comment #15:
@John D: if it is simple to fix Qt implementation it will avoid distinguishing java/qt implementations in inputdlg.m.
@jwe: this is probably a copy/paste error as the colon at the end of the line should prevent Octave from displaying the value.
|
Tue 17 Mar 2015 02:44:21 PM UTC, comment #14:
Wait, you get a 1x4 cell array for the expression
?? That doesn't look right, and is not what I see.
|
Tue 17 Mar 2015 12:15:08 PM UTC, comment #13:
The command line version (java prompt) returns correctly with size 4 1, so I guess need to change the _octave_link_input_dialog_ function to behave correctly.
|
Tue 17 Mar 2015 12:09:14 PM UTC, comment #12:
Running on octave and matlab, and pressing the OK button:
Octave:
Matlab 2010b:
|
Tue 17 Mar 2015 11:55:43 AM UTC, comment #11:
@Avinoam: no, according to the tests in comment #7, Matlab always returns a column cell vector.
In inputdlg.m, we have to first reshape the input into a row cell vector to comply with the c++ implementation of the dialog that segfaults otherwise (or fix this implementation) and then reshape the output to be compatible with ML.
|
Tue 17 Mar 2015 11:29:50 AM UTC, comment #10:
All of them fail:
should be
|
Tue 17 Mar 2015 11:25:13 AM UTC, comment #9:
Do the following test pass (I can't test at the moment)?
Also, there should be no space between "prompt" and "(:)" as it is a form of indexing, not a function call.
|
Tue 17 Mar 2015 10:54:36 AM UTC, comment #8:
How about this then
(file #33375)
|
Tue 17 Mar 2015 08:18:20 AM UTC, comment #7:
I checked in ML 2013a, the output is a column cell vector whatever the input shape:
|
Tue 17 Mar 2015 07:42:18 AM UTC, comment #6:
Hi,
@John: you can format the input cell unconditionally ("if" block not needed) in a row vector cell using simply "tmp = prompt(:).'" instead of a potentially slow for loop. If you choose to retain the if block, you should enclose the logical expression in parenthesis to follow Octave coding convention.
|
Mon 16 Mar 2015 10:10:55 PM UTC, comment #5:
Fix will all varied input cells
I need to check whether matlab formats output to be the same format as the input.
(file #33372)
|
Mon 16 Mar 2015 08:17:39 PM UTC, comment #4:
Matlab will also handle say a 2x2 array, shoing each element as a text field, going down the rows, left to right.
|
Mon 16 Mar 2015 08:15:08 PM UTC, comment #3:
That appears consistent with matlab.
creates a 2x1 cell
creates a 1x2 array.
However in matlab, inputdlg will work equally the same with both.
|
Mon 16 Mar 2015 07:08:53 PM UTC, comment #2:
Note that:
but
so in the latter case
does work.
|
Mon 16 Mar 2015 06:01:21 PM UTC, comment #1:
ALso does it in 4.0.0 rc1 in windows - gui mode only.
Running in cli mode appears to work fine.
|
Mon 16 Mar 2015 04:02:56 PM UTC, original submission:
I am attempting to define an input dialog with many fields with complex names and want to split the prompt over many lines.
If I do it with ellipses then everything is okay:
However, if I omit the ellipsis as below, the cell array is still parsed fine, but inputdlg crashes Octave entirely, e.g.
The cell array 'prompt2' is defined, but calling inputdlg on it results in a silent exit.
Perhaps it shouldn't work without the ellipsis, which is fine and fixes my problem for now, but I'd expect it to throw an error instead of crashing.
Experimental 3.8.2 GUI on Windows 7 Ultimate 64 bit, SP1
|