bugGNU Octave - Bugs: bug #44404, make distcheck fails due to cset...

 
 

bug #44404: make distcheck fails due to cset 737b5d449aaf

Submitter:  Mike Miller <mtmiller>
Submitted:  Mon 02 Mar 2015 02:37:35 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 04 Mar 2015 11:34:39 AM UTC, comment #7: 

I made a partial backout of 737b5d449aaf http://hg.savannah.gnu.org/hgweb/octave/rev/371aa9261b1a

The only reply I got from the xdg mailing list was that we should not worry about updating the mime cache, that we should leave it up to the user and downstream packagers.

Carnë Draug <carandraug>
Group Member
Mon 02 Mar 2015 07:22:11 PM UTC, comment #6: 

I have asked on the xdg mailing list about the recommended procedure. See http://lists.freedesktop.org/archives/xdg/2015-March/013464.html if you can give more details.

Carnë Draug <carandraug>
Group Member
Mon 02 Mar 2015 06:54:36 PM UTC, comment #5: 

I found this m4 macro https://gist.github.com/TingPing/324ae1d722a6c3a9ae17 for aclocal which seems to handle this installation and uninstallation with desktop files.

It calls --rebuild-mime-info-cache during install. During uninstall, it removes the files, and then updates the database.

Carnë Draug <carandraug>
Group Member
Mon 02 Mar 2015 06:33:32 PM UTC, comment #4: 

Actually, the recommendation I got from #gnome-hackers (on the gimp IRC server) was

+varbatim+
walters | do it under if test -z "$(DESTDIR)"
-verbatim-

but I think this would still leave the files around in the end.

Carnë Draug <carandraug>
Group Member
Mon 02 Mar 2015 06:22:33 PM UTC, comment #3: 

As far as distro packages go, yes this is something that would normally be handled by a deb or rpm package postinstall script. Packages are normally built in a chroot with a DESTDIR install or similar. Any steps that are needed to integrate with the rest of the system (ldconfig, update-desktop-database, etc.) are done in a separate postinst script.

So specific to Debian, if we keep this in the makefile, the Debian package will delete the file and instead execute update-desktop-database in the octave.postinst maintainer script.

Mike Miller <mtmiller>
Group Member
Mon 02 Mar 2015 04:29:42 PM UTC, comment #2: 

On comment #1 Rik said:

> The usual thing would be to add a clean-local rule that removed the extra files. But, we don't want to remove someone's mimeinfo.cache if it contains other entries besides just Octave.


Yes, but such rule could remove the cache file and then rebuild it again (without the Octave desktop files).

> Is this a rule that belongs with the distribution maintainer, like Debian, rather than with the individual software package?
>
> I think maybe the distribution takes care of re-building global cache files, updating ramdisks, etc.


I do not know. I will try to ask to the freedesktop.org people.

Carnë Draug <carandraug>
Group Member
Mon 02 Mar 2015 04:18:55 PM UTC, comment #1: 

The usual thing would be to add a clean-local rule that removed the extra files.  But, we don't want to remove someone's mimeinfo.cache if it contains other entries besides just Octave.

Is this a rule that belongs with the distribution maintainer, like Debian, rather than with the individual software package?

I think maybe the distribution takes care of re-building global cache files, updating ramdisks, etc.

Rik <rik5>
Group administrator
Mon 02 Mar 2015 02:37:35 AM UTC, original submission:  

Changeset http://hg.savannah.gnu.org/hgweb/octave/rev/737b5d449aaf causes 'make distcheck' to fail now. The error message is:


ERROR: files left after uninstall:
./share/applications/mimeinfo.cache
./share/info/dir


If I remove the --rebuild-mime-info-cache option, distcheck works again.

We do want distcheck to work. Is there a way to handle this better or should this change be backed out?

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Submitted the item)
  • -email is unavailable- added by mtmiller
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-04 carandraug StatusNone Fixed
        Open/ClosedOpen Closed
    2015-03-02 rik5 Carbon-CopyRemoved 72865 -
    2015-03-02 mtmiller Carbon-Copy- Added carandraug

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code