bugGNU Octave - Bugs: bug #44394, graphics_toolkit check assumes...

 
 

bug #44394: graphics_toolkit check assumes axes is directly under figure

Submitted by:  jsh <jsh>
Submitted on:  Sun 01 Mar 2015 06:54:08 AM UTC  
 
Category: PlottingSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 01 Mar 2015 07:19:58 PM UTC, comment #4:

Okay. It was my thought too that these functions would not be used intensively, and thus wouldn't present much of a performance issue.

Rik <rik5>
Project Administrator
Sun 01 Mar 2015 06:38:16 PM UTC, comment #3:

You are right but I don't think that there are any such case in the modified files: axes can always have an uipanel parent between them and their ancestor figure.

I don't think the modified files are meant to be used intensively so I don't expect a significant slowdown.

Pantxo Diribarne <pantxo>
Project Member
Sun 01 Mar 2015 06:24:40 PM UTC, comment #2:

Something to be aware of, ancestor() is much slower than using 'get (h, 'parent'). So if there are any cases where it is absolutely certain that the parent will be a figure it would be preferable to keep that syntax.

Rik <rik5>
Project Administrator
Sun 01 Mar 2015 02:25:09 PM UTC, comment #1:

Hi,

Thanks for your bug report. I have pushed a changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/f25fe5369022) in which I tried to find all occurrences of this assumption and use "ancestor" to find the figure ancestor.

Closing bug report.

Pantxo Diribarne <pantxo>
Project Member
Sun 01 Mar 2015 06:54:08 AM UTC, original submission:

in axis.m line 196:

if (strcmp (get (get (ca, "parent"), "__graphics_toolkit__"), "gnuplot"))

assumes that the axes is a child of the figure which now nay not necessarily be true, for example this fails:

Line 196 in axis.m should possibly be change to a recursive or better check mechanism. There could possibly also be other places where this will fail.

jsh <jsh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by pantxo (Posted a comment)
  • -unavailable- added by jsh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 01 Mar 2015 02:25:09 PM UTCpantxoCategoryGUI=>Plotting
      StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1