bugGNU Octave - Bugs: bug #44385, image package: empty out range...

 
 

bug #44385: image package: empty out range does not use default value

Submitted by:  Hartmut <hardy>
Submitted on:  Fri 27 Feb 2015 07:35:52 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 28 Feb 2015 06:41:49 PM UTC, comment #4:

Thanks for this amazingly fast fix. It works for me :)

Hartmut <hardy>
Sat 28 Feb 2015 05:10:55 PM UTC, comment #3:

Thank you for the report and fix. I have pushed the cset by Avinoam

http://hg.code.sf.net/p/octave/image/rev/9c932ea474dd

Carnë Draug <carandraug>
Project Member
Sat 28 Feb 2015 09:17:30 AM UTC, comment #2:

changeset attached

(file #33208)

Avinoam Kalma <avinoam>
Project Member
Sat 28 Feb 2015 08:23:10 AM UTC, comment #1:

Checking with debugger, it fails in line 143
the conditions that are true are
because out is empty.
I think that the solution is to add the lines
after line 114

Avinoam Kalma <avinoam>
Project Member
Fri 27 Feb 2015 07:35:52 PM UTC, original submission:

Here is a small script to show the behavior:

With Octave 3.8.2 and the image package in version 2.2.2 the last command results in an error message.

With Matlab this kind of easy gamma correction works fine, as you can see here for example: http://de.mathworks.com/help/images/contrast-adjustment.html

In the Octave help text of the function imadjust.n it is stated, that the second argument, as well as the third argument, default to [0 1] if not specified. But in this case this seems NOT to happen. The correct result as produced by
is not returned.

Further tests show, that the second argument of imadjust properly defaults to [0 1] if not given, but the third argument does NOT.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33208:  imadjust.diff added by avinoam (705B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by hardy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 28 Feb 2015 05:10:55 PM UTCcarandraugStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Release3.8.2=>other
      Summaryimage package: simple gamma correction with imadjust fails=>image package: empty out range does not use default value
    Sat 28 Feb 2015 09:17:30 AM UTCavinoamAttached File-=>Added imadjust.diff, #33208

    Back to the top


    Powered by Savane 3.1-cleanup1