bugGNU nano - Bugs: bug #44320, invoking external speller always...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #44320: invoking external speller always sets modified flag

Submitted by:  Cody A. Taylor <code_m>
Submitted on:  Fri 20 Feb 2015 03:47:00 AM UTC  
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  Benno Schulenberg <bens> Open/Closed:  Closed

Fri 20 Mar 2015 11:44:53 AM UTC, comment #5: 

Why a not-equal instead of a greater-than?  It simply hadn't occurred to me.  :)  But thinking about it a bit: a greater-than somehow suggests to me that it also might be a less-than, which naturally (but not obviously) is not the case.  My mind only thinks: if the timestamp is no longer the same as what it was, then... set modified.  So: unequal.

Thanks for testing.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 17 Mar 2015 09:22:38 PM UTC, comment #4: 

Looks good from a testing perspective.

I am curious why the timestamp check is a not-equals comparison and not a greater-than comparison? (For the sake of future readers). Granted, the external program should never set the mtime to something in history.

Cody A. Taylor <code_m>
Tue 17 Mar 2015 08:12:00 PM UTC, comment #3: 

Fixed in SVN, r5140.  Thanks for reporting.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sun 15 Mar 2015 07:53:30 PM UTC, comment #2: 

Proposed patch is attached.

(file #33353)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sat 21 Feb 2015 12:34:22 PM UTC, comment #1: 

I've posted the bug to nano-devel:
https://lists.gnu.org/archive/html/nano-devel/2015-02/msg00013.html .  Please watch for possible followups there.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 20 Feb 2015 03:47:00 AM UTC, original submission:  

Very simple, any invocation of the speller sets the modified flag regardless if any change was made. Will also set the modified flag if the speller made no suggestions.

Revision 5120.

nanorc speller setting is:

```
set speller "aspell -x -c"
```

Reproducing:
 1. Open any file.
 2. Invoke speller (^T).
 3. If the speller suggests anything do
   a. Exit (x) or ignore (i) all spelling suggestions.
 4. Modified flag is set.

Cody A. Taylor <code_m>

 

Attached Files
file #33353:  timestamping.patch added by bens (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by code_m (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-23 bens Open/ClosedOpen => Closed
    2015-03-17 bens StatusIn Progress => Fixed
    2015-03-15 bens Attached File- => Added timestamping.patch, #33353
        StatusNone => In Progress
        Assigned toNone => bens
    2015-02-21 bens Summaryinvoking speller causes modified flag to be set => invoking external speller always sets modified flag

    Back to the top


    Powered by Savane 3.6