bugGNU Octave - Bugs: bug #44162, prepad issues warnings when...

 
 

bug #44162: prepad issues warnings when prepadding strings

Submitted by:  None
Submitted on:  Mon 02 Feb 2015 08:42:29 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Oliver HeimlichOriginator Email: -unavailable-
Open/Closed: ClosedRelease: dev
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 03 Feb 2015 01:37:39 AM UTC, comment #5:

Fixed on the default branch:

http://hg.savannah.gnu.org/hgweb/octave/rev/107ec5195a47

Thanks for noticing and providing a patch. I included some simple tests for both prepad and postpad with strings.

Mike Miller <mtmiller>
Project Administrator
Mon 02 Feb 2015 09:34:33 PM UTC, comment #4:

And perhaps add some unit tests using strings to ensure this continues to work in the future.

Mike Miller <mtmiller>
Project Administrator
Mon 02 Feb 2015 09:32:38 PM UTC, comment #3:

Looks like postpad was fixed as part of the resolution to bug #37785, but not prepad. The same change that was made in http://hg.savannah.gnu.org/hgweb/octave/rev/c8e1b0213e34 should be applied here.

Mike Miller <mtmiller>
Project Administrator
Mon 02 Feb 2015 09:30:57 PM UTC, comment #2:

Please see the patch file from the first post. There is no need to disable the warning.

In the history I have found 16304:c8e1b0213e34 (#37785), which did the same fix for the postpad function.

Anonymous
Mon 02 Feb 2015 08:58:35 PM UTC, comment #1:

Just running "test prepad" confirms this.

Is it a matter of temporarily disabling the warning?

Philip Nienhuis <philipnienhuis>
Project Member
Mon 02 Feb 2015 08:42:29 PM UTC, original submission:

The prepad function creates a warning when the first parameter is a string. The postpad function creates no such warning. There was no warning in 3.8.2.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32976:  prepad-string-warning.patch added by None (339B - text/x-patch - This patch copies postpad's behaviour in prepad and disables the warning)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 Feb 2015 01:37:39 AM UTCmtmillerStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Mon 02 Feb 2015 08:58:35 PM UTCphilipnienhuisStatusNone=>Confirmed
    Mon 02 Feb 2015 08:42:29 PM UTCNoneAttached File-=>Added prepad-string-warning.patch, #32976

    Back to the top


    Powered by Savane 3.1-cleanup1