bugGNU Octave - Bugs: bug #44142, audio playblocking and...

 
 

bug #44142: audio playblocking and recordblocking should be interruptible with Ctrl-C

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Sat 31 Jan 2015 11:04:50 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 08 Feb 2015 05:31:35 AM UTC, comment #2:

Fixed with changeset http://hg.savannah.gnu.org/hgweb/octave/rev/b5a8f0f31664

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 01 Feb 2015 12:22:55 AM UTC, comment #1:

Same applies to audiorecorder's recordblocking method.

The attached diff fixes the problem for me, is this kind of check of the interrupt flag safe to do in this case? Is there another flag or library function to use instead? Otherwise, the loop is entirely data driven and does not break until the data is exhausted.

(file #32960)

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sat 31 Jan 2015 11:04:50 PM UTC, original submission:

The playblocking method is currently uninterruptible. It does not return control to the terminal until the audio has played through to the end. Someone could easily create an audio vector representing 24 hours and try to play it with playblocking. Ctrl-C while playblocking is going only results in the "Press Control-C again to abort" message. This should cause playblocking to stop early instead and return control to the terminal.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32960:  audio-interrupt.diff added by mtmiller (885B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Feb 2015 05:31:35 AM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sun 01 Feb 2015 12:22:55 AM UTCmtmillerAttached File-=>Added audio-interrupt.diff, #32960
      StatusNone=>Patch Submitted
      Assigned toNone=>mtmiller
      Summaryaudioplayer.playblocking should be interruptible with Ctrl-C=>audio playblocking and recordblocking should be interruptible with Ctrl-C

    Back to the top


    Powered by Savane 3.1-cleanup1