bugGNU Octave - Bugs: bug #44142, audio playblocking and...

 
 

bug #44142: audio playblocking and recordblocking should be interruptible with Ctrl-C

Submitter:  Mike Miller <mtmiller>
Submitted:  Sat 31 Jan 2015 11:04:50 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 08 Feb 2015 05:31:35 AM UTC, comment #2: 
Mike Miller <mtmiller>
Group Member
Sun 01 Feb 2015 12:22:55 AM UTC, comment #1: 

Same applies to audiorecorder's recordblocking method.

The attached diff fixes the problem for me, is this kind of check of the interrupt flag safe to do in this case? Is there another flag or library function to use instead? Otherwise, the loop is entirely data driven and does not break until the data is exhausted.

(file #32960)

Mike Miller <mtmiller>
Group Member
Sat 31 Jan 2015 11:04:50 PM UTC, original submission:  

The playblocking method is currently uninterruptible. It does not return control to the terminal until the audio has played through to the end. Someone could easily create an audio vector representing 24 hours and try to play it with playblocking. Ctrl-C while playblocking is going only results in the "Press Control-C again to abort" message. This should cause playblocking to stop early instead and return control to the terminal.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32960:  audio-interrupt.diff added by mtmiller (885B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-08 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2015-02-01 mtmiller Attached File- Added audio-interrupt.diff, #32960
        StatusNone Patch Submitted
        Assigned toNone mtmiller
        Summaryaudioplayer.playblocking should be interruptible with Ctrl-C audio playblocking and recordblocking should be interruptible with Ctrl-C

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code