bugunrtf - Bugs: bug #43929, ./config/ automake files are...

 
 

bug #43929: ./config/ automake files are symlinks in 0.21.9

Submitter:  Ken Dreyer <ktdreyer>
Submitted:  Sun 04 Jan 2015 03:52:12 AM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 24 Mar 2015 03:13:51 PM UTC, comment #1: 

Shipping the config/ contents as symbolic links was most definitely a mistake.

As far as I can see, both automake and the actual tar file build have to be performed manually for this to happen (because it appears that "make dist" fixes the links while building the archive).

We will coordinate and try to make sure that this does not happen again in a future release.


Jean-Francois Dockes <medoc>
Group administrator
Sun 04 Jan 2015 03:52:12 AM UTC, original submission:  

Starting with the 0.21.8 tarball, the automake files that are present in the ./config/ directory in the tarball are just symlinks.

This is fragile because the symlinks depend on a particular location for the targets. For example, the test-driver file is just a symlink to an automake installation in /usr:

unrtf-0.21.9/config/test-driver -> /usr/share/automake-1.13/test-driver

If I have automake installed to a different directory, or I have a different version of automake installed, then the build will fail. (This affects the Fedora Linux distribution, where we ship automake 1.14.)

The "-c" flag to automake will eliminate this problem. In fact the ./bootstrap helper script does invoke automake with the "-c" flag.

My guess is that when the 0.21.8 and 0.21.9 tarballs were created, the author may have simply ran "automake" by hand instead of using the ./bootstrap helper script.

Please consider using ./bootstrap for future releases.

Ken Dreyer <ktdreyer>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by medoc (Posted a comment)
  • -email is unavailable- added by ktdreyer (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-24 medoc Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code