buggnubg - Bugs: bug #43747, The external interface seems to be...

 
 

bug #43747: The external interface seems to be broken

Submitted by:  Philippe Michel <plm>
Submitted on:  Wed 03 Dec 2014 10:51:40 PM UTC  
 
Originator Name: Item Group: Other bug
Category: OtherRelease: 1.03-Release
Privacy: PublicOperating System: FreeBSD
OS Type: 64BitProcessor Type: Any
Severity: 4 - ImportantOpen/Closed: Closed
Assigned to: Michael Petch <mdpetch>Priority: 6
Status: Fixed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Dec 2014 10:02:20 PM UTC, comment #5:

Earlier today I committed a fix to CVS. Let me know if you still have problems.

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Thu 04 Dec 2014 12:52:12 AM UTC, comment #4:

I have identified the problem. There is a test case I didn't account for in the new external interface. There is a bug imho in the client side GNUbg code that sends 0x0a 0x00 at the end of each line it sends. In theory it should not be sending the nul terminating character as part of the command. The new external interface sees this unexpected 0x00 as an error.

In order to stay compatible with older software I'll amend the external interface to deal/accept 0x00 (nul) characters as part of the EOL.

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Thu 04 Dec 2014 12:34:02 AM UTC, comment #3:

Forget the last comment with the experiment it will not do what I was hoping it would.

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Wed 03 Dec 2014 11:45:30 PM UTC, comment #2:

As an experiment can you do this. Run the server as you have been but on the client copy of GNUbg do this:

set player 1 gnubg
set player 1 chequerplay evaluation plies 0
set player 1 cubedecision evaluation plies 0
set player 0 external localhost:10000
save settings
quit

So enter the settings, save them, exit gnubg. Now relaunch gnubg and issue this command:

new match 11

I am curious. Does this work or not?

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Wed 03 Dec 2014 11:20:57 PM UTC, comment #1:

The lack of error output on the interactive side is a deficiency in the client portion of the code that sends requests. When I rewrote the external interface I only made changes in the external interface server code. So that particular issue is something that has been lacking in previous versions. This probably went unnoticed since the old client side code probably never got in an error state.

Now of course there is a problem parsing whatever is sent. I can reproduce something similar on my Linux box here. I'll take a look at it tonight or tomorrow and provide a fix.

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Wed 03 Dec 2014 10:51:40 PM UTC, original submission:

When using the internal interface, something doesn't work any more when sending or receiving the board state (tcpdump log attached).
Moreover, there is no error reporting to the interactive side of the connection.

Philippe Michel <plm>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32588:  instance1.log added by plm (518B - application/octet-stream)
file #32589:  instance2.log added by plm (2KiB - application/octet-stream)
file #32590:  tcpdump.log added by plm (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mdpetch (Posted a comment)
  • -unavailable- added by plm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 10 Dec 2014 02:35:17 AM UTCmdpetchOpen/ClosedOpen=>Closed
    Thu 04 Dec 2014 02:30:52 PM UTCmdpetchStatusConfirmed=>Fixed
    Wed 03 Dec 2014 11:20:57 PM UTCmdpetchSeverity3 - Normal=>4 - Important
      Assigned toNone=>mdpetch
      Priority5 - Normal=>6
      StatusNone=>Confirmed
    Wed 03 Dec 2014 10:51:40 PM UTCplmAttached File-=>Added instance1.log, #32588
      Attached File-=>Added instance2.log, #32589
      Attached File-=>Added tcpdump.log, #32590

    Back to the top


    Powered by Savane 3.1-cleanup1