bugGNU Octave - Bugs: bug #43691, findpeaks: "extra"...

 
 

bug #43691: findpeaks: "extra" undefined if no peak matches criteria

Submitted by:  Andreas Weber <andy1978>
Submitted on:  Tue 25 Nov 2014 09:08:43 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 11 Jan 2015 04:59:02 PM UTC, comment #3:

Applied your patch in https://sourceforge.net/p/octave/signal/ci/56e2f21ec88366ae233a7ab61ee6c4813eedf93f/

Thanks!

Mike Miller <mtmiller>
Project Administrator
Fri 02 Jan 2015 11:15:28 PM UTC, comment #2:

@Mike: Can I go ahead and push the patch?

Andreas Weber <andy1978>
Project Member
Tue 25 Nov 2014 09:24:27 AM UTC, comment #1:

Patch attached

(file #32539)

Andreas Weber <andy1978>
Project Member
Tue 25 Nov 2014 09:08:43 AM UTC, original submission:

signal-1.3.0:

this is because in findpeaks.m:225, "extra" is never populated if not even one peak matches the MinPeakWidth, MinPeakHeight... criterias. I think extra should returns just an empty struct in this case.

Btw, if the peaks are detected I get

from

I would suggest using bsxfun (@minus, idx_s, idx_s') if this is intended.

Andreas Weber <andy1978>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32539:  signal_bug43691.patch added by andy1978 (1017B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by andy1978
  • -unavailable- added by andy1978 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 11 Jan 2015 04:59:02 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 02 Jan 2015 11:15:28 PM UTCandy1978Carbon-Copy-=>Added mtmiller
    Tue 25 Nov 2014 09:24:27 AM UTCandy1978Attached File-=>Added signal_bug43691.patch, #32539
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1