bugGNU Octave - Bugs: bug #43602, spparms "defaults"...

 
 

bug #43602: spparms "defaults" argument should be "default"

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Thu 13 Nov 2014 08:30:11 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 18 Nov 2014 12:19:18 PM UTC, comment #4:

Pushed submitted patch eb20020f36b5

http://hg.savannah.gnu.org/hgweb/octave/rev/eb20020f36b5

and deprecated "defaults" with bcec6f9d1596

http://hg.savannah.gnu.org/hgweb/octave/rev/bcec6f9d1596

Carnë Draug <carandraug>
Project Member
Tue 18 Nov 2014 05:55:55 AM UTC, comment #3:

Agreed. The patch is fine. The deprecation cset should produce a warning if 'defaults' is used so that people know to change their code. After two releases we can get rid of it.

Rik <rik5>
Project Administrator
Fri 14 Nov 2014 01:15:06 PM UTC, comment #2:

The patch seems right to me. The only issue is whether we should deprecate "defaults" as a possible argument. I would prefer to deprecate it just to keep things cleaner. If no one opposes I will push this cset and then add another one that deprecates the previous "defaults" argument.

Carnë Draug <carandraug>
Project Member
Thu 13 Nov 2014 09:28:50 PM UTC, comment #1:

Hi guyz,

attached you'll find the patch i wrote with the patient help of carandraug. Thank you!

Best regards,
Mark

Anonymous
Thu 13 Nov 2014 08:30:11 PM UTC, original submission:

The function spparms accepts the string "defaults" as first argument to reset the parameters. However, Matlab documentation takes "default". When fixing this, should we start to deprecate the other or accept both?

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32429:  spparms-default-fix.cset added by None (2KiB - application/octet-stream - Attached the patch proposed)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by carandraug (author of the patch)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Nov 2014 12:19:18 PM UTCcarandraugStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
      Carbon-Copy-=>Added -unavailable-
    Tue 18 Nov 2014 05:55:55 AM UTCrik5StatusNone=>Patch Submitted
    Thu 13 Nov 2014 09:24:17 PM UTCNoneAttached File-=>Added spparms-default-fix.cset, #32429

    Back to the top


    Powered by Savane 3.1-cleanup1