bugCompact Disc Input and Control Library - Bugs: bug #43444, cd-paranoia end of span

 
 

bug #43444: cd-paranoia end of span

Submitted by:  None
Submitted on:  Mon 20 Oct 2014 02:24:24 PM UTC  
 
Category: NoneSeverity: 5 - Average
Item Group: cd-paranoiaStatus: None
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Originator Email: -unavailable-Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 26 Oct 2014 05:06:04 AM UTC, comment #7:

You are correct and I am wrong. Commit 8e8aa9c adds your patch. Thanks.

I originallygot the patch sense backwards and hadn't realized that the patch was to make the code more like cdparanoia's code. And looking in the git history, it looks like I erroneously added that code to try to address another problem.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Fri 24 Oct 2014 07:22:48 PM UTC, comment #6:

I think removing "if (track2 < d->tracks) track2 = d->tracks;" would make it exactly like cdparanoia (xiph) so no comment is necessary because it would mimic exactly?

Can't see anything similar to "if (track2 < d->tracks) track2 = d->tracks;" in the cdparanoia (xiph) source.

But I guess I can be wrong. :)

Anonymous
Tue 21 Oct 2014 08:44:41 AM UTC, comment #5:

Thanks for tracking this further.

Given what you report I think the difference is all in getting d->tracks. I suspect cdparanoia doesn't have to be concerned about multiple (non-audio) sessions like libcdio does since only purports to work with (single-session) audio CDs.

So the change you propose is probably right for libcdio-paranoia and would do no harm in cdparanoia although it isn't needed for reasons above.

It would be nice to rework the patch to add the discussion we have here as to why the code is different. If you don't have time or don't want todo, I'll do later when I get a chance.

Again, thanks for the help.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Tue 21 Oct 2014 08:12:47 AM UTC, comment #4:

Compared libcdio-paranoia and cdparanoia (xiph) in virtualbox with a cd that got 48 audio tracks.

Command: ./cd-paranoia -- 1-2

libcdio-paranoia output:

Ripping from sector 0 (track 1 [0:00.00])
to sector 13472 (track 48 [1:29.46])

Command: ./cdparanoia -- 1-2

cdparanoia(xiph) output:

Ripping from sector 0 (track 1 [0:00.00])
to sector 13472 (track 2 [1:29.46])

So i think this is a bug of libcdio-paranoia and not cdparanoia (xiph). It's purely cosmetal bug for regular cd's by just printing the wrong information for the "Ripping from sector..." message.

But if you use enhanced cd's this will fail on the cdda_track_audio_p check because it will iterate over the data track to.

if (track2 < d->tracks) track2 = d->tracks;
for( i=track1; i<=track2; i++ )
if(i != 0 && !cdda_track_audiop(d,i)){

Anonymous
Tue 21 Oct 2014 07:10:36 AM UTC, comment #3:

> Had a look at cdparanoia and can't see that it sets ...


Right. So the question is whether that's a bug in cdparanoia or perhaps not because of some other thing elsewhere. If a bug in cdparanoia, I guess it should be reported. If not, then possibly libcdio cd-paranoia should adjust something elsewhere as it did for setting the adjusting the drive speed.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Tue 21 Oct 2014 05:42:18 AM UTC, comment #2:

Had a look at cdparanoia and can't see that it sets

if (track2 < d->tracks) track2 = d->tracks;

after parsing the span.

Anonymous
Tue 21 Oct 2014 12:34:19 AM UTC, comment #1:

Is this a bug in cdparanioa as well? It looks the the code in libdio cd-paranoia mimics exactly what's done in cdparanoia.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Mon 20 Oct 2014 02:24:24 PM UTC, original submission:

End of span seems to always default to last track with version 0.93.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32303:  cd-paranoia.c.patch added by None (627B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Oct 2014 05:06:29 AM UTCrockyOpen/ClosedOpen=>Closed
    Tue 21 Oct 2014 12:34:19 AM UTCrockyAssigned toNone=>rocky
    Mon 20 Oct 2014 02:24:24 PM UTCNoneAttached File-=>Added cd-paranoia.c.patch, #32303

    Back to the top


    Powered by Savane 3.1-cleanup1