bugGNU Octave - Bugs: bug #42980, GUI: when undocking editor, focus...

 
 

bug #42980: GUI: when undocking editor, focus is in documentation rather than terminal

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Wed 13 Aug 2014 07:56:33 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 25 Mar 2015 04:10:25 PM UTC, comment #9: 

Extended to the case where a tabbed widget is closed and pushed with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/643de08e524c

Torsten Lilge <ttl>
Project Member
Tue 24 Mar 2015 09:28:27 PM UTC, comment #8: 

OK seems to work fine on Linux & Windows.
The initial annoyance is gone. So I think this patch suffices, thanks very much.

Will you push it?

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Mar 2015 07:28:04 AM UTC, comment #7: 

Thanks Torsten, I'll try a.s.a.p.

If tabs are inserted/deleted outside undocking actions, of course tracking is probably in vain. So big chance that the latest patch will be sufficient. I'll let you know.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 23 Mar 2015 08:53:02 PM UTC, comment #6: 

I understand your point but I doubt that it is that simple to keep track of all possible situations with changing states of all widgets. Attached please find a patch with the approach of saving the widget that previously had the focus among the tabbed widgets.

It does not yet include a solution for the case that a widget is manually added to already tabbed widgets. When this is done, no more information is available on the previously active widget in this tabbed stack.

(file #33434)

Torsten Lilge <ttl>
Project Member
Sat 21 Mar 2015 10:58:51 PM UTC, comment #5: 

Thanks for your attention, Torsten.

I'd think what needs to be changed is not so much the tab order (the symptom), but the fact that it is the tab order that determines what pane gets focus once another pane is undocked (the underlying cause).
The last active tab before some other pane is undocked simply  needs to be remembered, so that focus can return there. Wherever it is in the tab order shouldn't matter at all.
I hope I've made myself clear.

This probably holds equally for any group of panes stacked on top of each other.

Philip Nienhuis <philipnienhuis>
Project Member
Sat 21 Mar 2015 10:19:42 AM UTC, comment #4: 

As Doug mentioned in comment #2 the behavior depends on the order of the tabs. The attached patch switches the tab order every time the focus changes. I am not sure if this behavior is what users expect/want.

(file #33416)

Torsten Lilge <ttl>
Project Member
Thu 19 Mar 2015 09:58:19 PM UTC, comment #3: 

Ping!

Any progress?

Philip Nienhuis <philipnienhuis>
Project Member
Mon 17 Nov 2014 03:11:41 PM UTC, comment #2: 

I tried this and found that the focus goes to the next tab to the right of where the editor tab was.
If the tabs are   "command edit doc " then it moves to doc
But if the tabs are " edit command  doc" then it goes to command

Doug Stewart <dastew>
Wed 13 Aug 2014 09:18:04 PM UTC, comment #1: 

In a just compiled 3.9.0+ Octave's behavior is better.

However, in 4.1.0+ (built an hour ago) it still works as described in the bug report.

I suppose both use the same octave config file.

Philip Nienhuis <philipnienhuis>
Project Member
Wed 13 Aug 2014 07:56:33 PM UTC, original submission:  

A minor annoyance:

When the GUI contains a terminal and documentation tab (as usual after a first start of a just installed Octave), one types "edit foo.m" in the terminal, and then undocks the editor, the user is shown the documentation tab rather than the terminal.

Expected behavior would be to be returned to the terminal rather than documentation tab.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33434:  bug42980_02.patch added by ttl (3KiB - text/x-diff)
file #33416:  bug42980_01.patch added by ttl (932B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by dastew (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-25 ttl StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2015-03-24 philipnienhuis StatusNone => Ready For Test
    2015-03-23 ttl Attached File- => Added bug42980_02.patch, #33434
    2015-03-21 ttl Attached File- => Added bug42980_01.patch, #33416
    2014-08-13 philipnienhuis Release3.8.0 => dev

    Back to the top


    Powered by Savane 3.5