bugGNU Octave - Bugs: bug #42936, set(gca, 'xtick', []) fails to...

 
 

bug #42936: set(gca, 'xtick', []) fails to remove ticks [PATCH]

Submitted by:  Serviscope Minor <serviscope_minor>
Submitted on:  Thu 07 Aug 2014 04:18:47 PM UTC  
 
Category: Plotting with gnuplotSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 08 Aug 2014 04:53:45 PM UTC, comment #5:

I modified your patch to use the Octave coding conventions and checked it in here (http://hg.savannah.gnu.org/hgweb/octave/rev/1ad621d894ba).

The list of coding conventions is in the pdf manual in Appendix D. But what I did was simple

1) Use space between function name and opening parenthesis. We cuddle the parenthesis when the operation is indexing and this serves as a nice visual clue.

2) Use '##' to start stand-alone comments.

3) Use enclosing parentheses around test conditions in if statements as in the C language.

4) Changed isequal (XXX, []) to just isempty (XXX)

Thanks for the patch and I'm closing the report now.

Rik <rik5>
Project Administrator
Fri 08 Aug 2014 03:53:49 PM UTC, comment #4:

Remove debugging lines from the patch.

(file #31869)

Serviscope Minor <serviscope_minor>
Fri 08 Aug 2014 03:43:06 PM UTC, comment #3:

Patch was buggy for the X axis on the top.

New patch attached.

(file #31868)

Serviscope Minor <serviscope_minor>
Fri 08 Aug 2014 12:29:37 PM UTC, comment #2:

Haha, it helps to read file names rather than just randomly attach them!

Try this one instead.

(file #31866)

Serviscope Minor <serviscope_minor>
Thu 07 Aug 2014 11:18:34 PM UTC, comment #1:

Could you re-post your patch for removing xticks? The one that is attached is for honoring the color of title objects.

Rik <rik5>
Project Administrator
Thu 07 Aug 2014 04:18:47 PM UTC, original submission:

Title says it all, more or less.

Serviscope Minor <serviscope_minor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by serviscope_minor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Aug 2014 04:53:45 PM UTCrik5StatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Fri 08 Aug 2014 03:53:49 PM UTCserviscope_minorAttached File-=>Added serviscopeMinors-no-x-ticks-fix3.diff, #31869
    Fri 08 Aug 2014 03:43:06 PM UTCserviscope_minorAttached File-=>Added serviscopeMinors-no-x-ticks-fix2.diff, #31868
    Fri 08 Aug 2014 12:29:37 PM UTCserviscope_minorAttached File-=>Added serviscopeMinors-no-x-ticks-fix.diff, #31866
    Thu 07 Aug 2014 11:18:34 PM UTCrik5StatusNone=>Need Info
    Thu 07 Aug 2014 04:18:47 PM UTCserviscope_minorAttached File-=>Added serviscopeMinors-title-color-fix.diff, #31859

    Back to the top


    Powered by Savane 3.1-cleanup1