bugfindutils - Bugs: bug #4293, make install does not respect...

 
 

bug #4293: make install does not respect DESTDIR when generating localstatedir

Submitted by:  Andreas Metzler <ametzler>
Submitted on:  Sun 13 Jul 2003 09:04:37 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Open/Closed: Closed
Release: NoneFixed Release: 4.2.5

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 08 Nov 2004 09:58:29 PM UTC, comment #3:

This problem is fixed in the CVS code for findutils.
To resolve your problem, you could either wait for the
next official release of findutils, or check out a copy
of the code from the CVS repository for findutils.

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 07 Nov 2004 08:37:28 AM UTC, comment #2:

Jay wrote:

> Yours is a clearly-worded comment, but I don't understand > it. Firstly, the construct you're talking about appears in > the Makefile.in, but not in the Makefile.am file. Hence it > is being put into the Makefile.in file by Automake. Is
> this a bug in Automake?


The construct appears in both Makefile.am (line and Makefile.in.
grep 'mkinstalldirs \$(locals' locate/Makefile.*
See patch attached to the bugreport, no bug in automake.

> Secondly, while I understand the physical nature of the
> change you suggest, what is its effect and why is it
> necessary?


"make DESTDIR" is designed to completely install the software under a temporary different location instead of /, it is e.g. used to build rpm or Debian packages. (During build you install in temporary directory as unprivileged user, tar it up and you are basically done.)

Currently locate/Makefile.* does not respect DESTDIR completely, with "make DESTDIR=/tmp/find install" it will put locate in /tmp/find/usr/bin/locate but it will try to generate the localstatedir (used for the locate-db) in /, i.e. try "mkdir /$localstatedir" instead of "mkdir /tmp/find/$localstatedir".

cu andreas

PS: sorry for the delayed response, but savannah had failed to send me a emailnotification on your followup.

Andreas Metzler <ametzler>
Sun 31 Oct 2004 05:10:39 PM UTC, comment #1:

Yours is a clearly-worded comment, but I don't understand it. Firstly, the construct you're talking about appears in the Makefile.in, but not in the Makefile.am file. Hence it is being put into the Makefile.in file by Automake. Is this a bug in Automake?

Secondly, while I understand the physical nature of the change you suggest, what is its effect and why is it necessary?

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 13 Jul 2003 09:04:37 AM UTC, original submission:

Version: 4.1.20

locate/Makefile.* does not respect DESTDIR when generating localstatedir

Fix is straightforward, change locate/Makefile.*
- $(top_srcdir)/mkinstalldirs $(localstatedir)
+ $(top_srcdir)/mkinstalldirs $(DESTDIR)$(localstatedir)

cu andreas

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #925:  fixbroken-DESTDIR.diff added by ametzler (1KiB - text/plain - patch against current CVS)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 19 Nov 2004 11:18:58 PM UTCjayAssigned toNone=>jay
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.2.5
Mon 08 Nov 2004 09:58:29 PM UTCjayStatusNone=>Fixed
Sun 07 Nov 2004 08:25:40 AM UTCametzlerAttached File-=>Added fixbroken-DESTDIR.diff, #1842

Back to the top


Powered by Savane 3.1-cleanup1