bugGNU Octave - Bugs: bug #42915, number of jobs when pkg runs make

 
 

bug #42915: number of jobs when pkg runs make

Submitter:  Carnë Draug <carandraug>
Submitted:  Tue 05 Aug 2014 01:22:49 PM UTC
   
 
Category:  Octave Function Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  carandraug
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 06 Aug 2014 12:13:49 AM UTC, comment #4: 

Fixed in cset 7141d9728ee0, see http://hg.savannah.gnu.org/hgweb/octave/rev/7141d9728ee0





This problem has been fixed in the development version. The fix
will be available in the next major software release. Thank you
for your bug report.

Carnë Draug <carandraug>
Group Member
Tue 05 Aug 2014 11:10:45 PM UTC, comment #3: 

Oh! I never realized we had a nproc function in Octave. I was referring to making a system call to nproc. Looking at nproc()'s documentation, it seems it already checks the value of OMP_NUM_THREADS so all I need to do is use `nproc ("overridable")`.

Carnë Draug <carandraug>
Group Member
Tue 05 Aug 2014 03:36:17 PM UTC, comment #2: 

And if you really want it to be user-configurable, you can use nproc ("overridable") which respects OMP_NUM_THREADS if it is defined.

Mike Miller <mtmiller>
Group Member
Tue 05 Aug 2014 03:15:08 PM UTC, comment #1: 

We use the nproc module from gnulib so the command should be available to Octave on all platforms (Linux, Mac, Windows).  This seems like an easy optimization.

Rik <rik5>
Group administrator
Tue 05 Aug 2014 01:22:49 PM UTC, original submission:  

This is just a feature request, a nice idea from `serviscopeMinor` on the IRC.  I could implement it, seems easy enough, but would like some discussion about it.

The problem is that pkg install can take a long time to install some packages because `make` runs with only one job at a time. We could have a massive improvements if it used all cores, but what should be used as default?

In Linux, we could use `nproc` but that wouldn't allow configuration. What about checking the value of an environment variable such as OMP_NUM_THREADS ? And if this is not defined, should we default to 1 or check nproc? Googling for a bit sounds like NUMBER_OF_PROCESSORS is the variable name to use on windows. Does anyone knows anything about Mac?

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-08-06 carandraug StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code