bugGNU Octave - Bugs: bug #42915, number of jobs when pkg runs make

 
 

bug #42915: number of jobs when pkg runs make

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Tue 05 Aug 2014 01:22:49 PM UTC  
 
Category: Octave FunctionSeverity: 1 - Wish
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: Carnë Draug <carandraug>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Aug 2014 12:13:49 AM UTC, comment #4:

Fixed in cset 7141d9728ee0, see http://hg.savannah.gnu.org/hgweb/octave/rev/7141d9728ee0

This problem has been fixed in the development version. The fix
will be available in the next major software release. Thank you
for your bug report.

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Tue 05 Aug 2014 11:10:45 PM UTC, comment #3:

Oh! I never realized we had a nproc function in Octave. I was referring to making a system call to nproc. Looking at nproc()'s documentation, it seems it already checks the value of OMP_NUM_THREADS so all I need to do is use `nproc ("overridable")`.

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Tue 05 Aug 2014 03:36:17 PM UTC, comment #2:

And if you really want it to be user-configurable, you can use nproc ("overridable") which respects OMP_NUM_THREADS if it is defined.

Mike Miller <mtmiller>
Project Administrator
Tue 05 Aug 2014 03:15:08 PM UTC, comment #1:

We use the nproc module from gnulib so the command should be available to Octave on all platforms (Linux, Mac, Windows). This seems like an easy optimization.

Rik <rik5>
Project Administrator
Tue 05 Aug 2014 01:22:49 PM UTC, original submission:

This is just a feature request, a nice idea from `serviscopeMinor` on the IRC. I could implement it, seems easy enough, but would like some discussion about it.

The problem is that pkg install can take a long time to install some packages because `make` runs with only one job at a time. We could have a massive improvements if it used all cores, but what should be used as default?

In Linux, we could use `nproc` but that wouldn't allow configuration. What about checking the value of an environment variable such as OMP_NUM_THREADS ? And if this is not defined, should we default to 1 or check nproc? Googling for a bit sounds like NUMBER_OF_PROCESSORS is the variable name to use on windows. Does anyone knows anything about Mac?

Carnë Draug <carandraug>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Aug 2014 12:14:18 AM UTCcarandraugStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1