bugGNU TeXmacs - Bugs: bug #42821, Undo and star signifying modified...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #42821: Undo and star signifying modified in title go wrong with multiple windows

Submitted by:  Victor Porton <porton>
Submitted on:  Mon 21 Jul 2014 10:51:11 PM UTC  
 
Category: EditorPriority: 5 - Normal
Item Group: ErrorStatus: Wont Fix
Privacy: PublicAssigned to: Joris van der Hoeven <vdhoeven>
Originator Name: Open/Closed: Closed
Release: 1.99.2Release: None
Fixed Release: NoneFixed Release: 
Keywords: 

(Jump to the original submission Jump to the original submission)

Fri 22 Aug 2014 12:44:00 PM UTC, comment #11:

For undo stuff, there is an opened bug here : https://savannah.gnu.org/bugs/?42862. I close this one.

Francois Poulain <fpoulain>
Project Member
Fri 22 Aug 2014 12:42:22 PM UTC, comment #10:

I don't reproduce this bug.

Francois Poulain <fpoulain>
Project Member
Fri 22 Aug 2014 12:40:18 AM UTC, comment #9:

Your patch https://savannah.gnu.org/support/download.php?file_id=31753 makes that I cannot save an edited file at all! (even when using only one TeXmacs window)

Victor Porton <porton>
Tue 19 Aug 2014 09:25:59 AM UTC, comment #8:

> When I edit text in one of two "cloned" windows, I can't undo it in the other window.


Ya, it is a bug.

Francois Poulain <fpoulain>
Project Member
Mon 18 Aug 2014 12:04:32 AM UTC, comment #7:

I've applied the patch to TeXmacs 1.99.2.

Now star in the window title seems to work correctly.

But a bug remain:

When I edit text in one of two "cloned" windows, I can't undo it in the other window.

Accordingly MVC paradigm two windows should show views of the same model and thus undo should work the same way in each of the two windows.

I am awaiting to fix this bug, as it may prevent me to write my book, and this is important.

Victor Porton <porton>
Tue 29 Jul 2014 07:54:48 AM UTC, comment #6:

I wondered if there is no more straightforward way to get the windows list. I am not used to edit those part of TeXmacs.

Francois Poulain <fpoulain>
Project Member
Mon 28 Jul 2014 02:46:30 PM UTC, comment #5:

"Miguel's hack, Miguel's hack"... Miguel's perfectly fine implementation, you mean! X-D (Ok, agreed, I should've cycled through all windows)

The patch seems fine to me. I say apply it.

Miguel de Benito <mdbenito>
Project Member
Tue 22 Jul 2014 02:04:49 PM UTC, comment #4:

Here is a patch.

(file #31753)

Francois Poulain <fpoulain>
Project Member
Tue 22 Jul 2014 01:08:14 PM UTC, comment #3:

Ok, I got it. I guess it is due to Miguel's hack. But the resolution may be hard.

Francois Poulain <fpoulain>
Project Member
Tue 22 Jul 2014 12:07:24 PM UTC, comment #2:

Start TeXmacs, open this file:

<TeXmacs|1.99.2>

<style|generic>

<\body>
X
</body>

Clone the window.

Type y after X.

Star appears only in the first window. For star to appear in the second (cloned) window, the user needs to switch to that second window. When the user switches to the second window, the star appear there also.

I think, enough for now. I may conceive a more difficult scenario, but the above is enough to see a bug.

Debian Linux "testing" with Mutter 3.12.1+really+3, Gnome Shell 3.8.4-8.1.

Victor Porton <porton>
Tue 22 Jul 2014 08:21:48 AM UTC, comment #1:

Could you please describe the behaviour encountered in a reproducible way?

Francois Poulain <fpoulain>
Project Member
Mon 21 Jul 2014 10:51:11 PM UTC, original submission:

When I open two windows with the same file, using "View"/"Clone window", the star in the title denoting that the file was modified behaves in a strange way.

Sometimes I have the left window with star and the right one without star, sometimes reversely. When I press Ctrl+Z it makes the current window without a star as it should be, but at the same time it switches star on in the second window (one is corrected, the other is made wrong by a single Ctrl+Z in one of the two windows).

It seems that Undo menu item works in a wrong way, too.

TeXmacs 1.0.7.18 and 1.99.2 on Debian Linux "testing".

Victor Porton <porton>

 

Attached Files
file #31753:  patch-42821.diff added by fpoulain (977B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mdbenito (Posted a comment)
  • -unavailable- added by porton (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Aug 2014 12:44:00 PM UTCfpoulainStatusReady For Test=>Wont Fix
      Open/ClosedOpen=>Closed
    Tue 22 Jul 2014 03:29:48 PM UTCfpoulainAssigned toNone=>vdhoeven
    Tue 22 Jul 2014 02:04:49 PM UTCfpoulainAttached File-=>Added patch-42821.diff, #31753
      StatusConfirmed=>Ready For Test
    Tue 22 Jul 2014 01:08:14 PM UTCfpoulainStatusNeed Info=>Confirmed
    Tue 22 Jul 2014 08:26:06 AM UTCfpoulainStatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup1