bugDenemo - Bugs: bug #42664, OBS patch for 1.1.6

 
 

bug #42664: OBS patch for 1.1.6

Submitted by:  None
Submitted on:  Wed 02 Jul 2014 03:10:15 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 02 Jul 2014 06:13:29 PM UTC, comment #6:

Ah it's linked directly from there, just at the bottom where it says "Create your own download page".

Anonymous
Wed 02 Jul 2014 06:08:46 PM UTC, comment #5:

The link i gave in the previous comment leads to the downoad storage area and is web browsable. I don't know of the file you refer to, I've never come acros such ones. Better link to this page in denemo.org download section:

http://software.opensuse.org/download.html?project=home%3Aedogawa&package=denemo
as it presents the steps to install the package, for each supplied OS variant.

There's even a wiki page somewhere on opensuse.org that explains how to embed these .ymp one-click buttons, if you're interested, i can look that up, too.

Anonymous
Wed 02 Jul 2014 04:42:06 PM UTC, comment #4:

It has just occurred to me that people visiting the downloads page on denemo.org may find a link to these packages useful.
I see things like

http://download.opensuse.org/repositories/home:/edogawa/Fedora_19/i686/denemo-1.1.6-16.1.i686.rpm.meta4

when I follow the link you give. I wonder if those are what we should be putting on the page - or, to avoid the links becoming stale would users of, say Fedora-19 be happy to follow the link you give to find the latest package specific to their distro?

Richard Shann <rshann>
Project Administrator
Wed 02 Jul 2014 04:19:53 PM UTC, comment #3:

Thanks in turn, i really don't understand enough of this, so i changed the patch also for my build now, and it passes the check...

but, just out of ignorance and curiosity, what about the static function do_set_playbutton (gboolean paused) that gets passed to? shouldn't it have a gpointer as parameter in the definition, not a gboolean?

anyway, denemo 1.1.6 packages for several openSUSE versions and Fedora 19/20 are ready now in my OBS project at

http://download.opensuse.org/repositories/home:/edogawa/

Greetings, Edgar

Anonymous
Wed 02 Jul 2014 04:18:48 PM UTC, comment #2:

Thanks in turn, i really don't understand enough of this, so i changed the patch also for my build now, and it passes the check...

but, just out of ignorance and curiosity, what about the static function do_set_playbutton (gboolean paused) that gets passed to? shouldn't it have a gpointer as parameter in the definition, not a gboolean?

anyway, denemo 1.1.6 packages for several openSUSE versions and Fedora 19/20 are ready now in my OBS project at

http://download.opensuse.org/repositories/home:/edogawa/

Greetings, Edgar

Anonymous
Wed 02 Jul 2014 03:34:31 PM UTC, comment #1:

Thank you for trying to fix this warning. However, the fix you propose does not have the desired effect (the pointer &paused that is passed will always evaluate to true).
The correct fix is to cast the value of the variable "paused" to a pointer, this fix is now in git.

Richard Shann <rshann>
Project Administrator
Wed 02 Jul 2014 03:10:15 PM UTC, original submission:

Hello, here I attach the patch needed to make denemo pass the OBS checks, thanks go to falktx of KXStudio for resolving this.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31667:  denemo-OBS.patch added by None (697B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rshann (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Jul 2014 03:34:31 PM UTCrshannStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 02 Jul 2014 03:10:15 PM UTCNoneAttached File-=>Added denemo-OBS.patch, #31667

    Back to the top


    Powered by Savane 3.1-cleanup1