bugGNUstep - Bugs: bug #42645, Use libgcrypt only if needed

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #42645: Use libgcrypt only if needed

Submitted by:  Yavor Doganov <yavor>
Submitted on:  Sun 29 Jun 2014 06:36:19 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Mon 30 Jun 2014 06:30:07 AM UTC, comment #1:

Thanks very much, I missed that change in gnutls.
I have applied your patch to svn trunk.

Richard Frith-Macdonald <CaS>
Project Member
Sun 29 Jun 2014 06:36:19 PM UTC, original submission:

Currently, +[GSTLSObject initialize] calls uncoditionally gcry_control, which is superfluous with recent (~4 years old) GnuTLS releases.
As of version 2.11 GnuTLS does not depend on gcrypt initialization, as its NEWS file indicates:

Version 2.11.1 switched to nettle as the default crypto backend, and support for libgcrypt was removed entirely in 2.99.2.

Proposed patch attached.

(P.S. The AC_MSG_WARN call if gcrypt is not found is redundant since there is AC_MSG_ERROR a few lines below. As a side (minor) issue, it is considered poor practice to nest AC_MSG_CHECKING/AC_MSG_RESULT because it leads to ugly and/or confusing output like:
It is not immediately clear to the user what the lone "yes" is for. It is even more confusing if there are mixed "yes" and "no" results.)

Yavor Doganov <yavor>

 

Attached Files
file #31636:  use-gcrypt-if-needed.patch added by yavor (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by yavor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 30 Jun 2014 06:30:07 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 29 Jun 2014 06:36:19 PM UTCyavorAttached File-=>Added use-gcrypt-if-needed.patch, #31636

    Back to the top


    Powered by Savane 3.1-cleanup1