bugGNU Octave - Bugs: bug #42586, bogus identifier error in GUI if...

 
 

bug #42586: bogus identifier error in GUI if comment string contains 'name'

Submitted by:  Chris Mumby <chrismumby>
Submitted on:  Thu 19 Jun 2014 11:14:30 AM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: John Donoghue <lostbard>
Originator Name: Chris MumbyOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 22 Jun 2014 08:36:33 PM UTC, comment #8:

Closing bug report as fixed

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sun 22 Jun 2014 05:01:07 PM UTC, comment #7:

John, your patch fixes the issue on my system.

Torsten <ttl>
Project Member
Sun 22 Jun 2014 11:24:20 AM UTC, comment #6:

Pushed http://hg.savannah.gnu.org/hgweb/octave/rev/9a70705dc616

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sat 21 Jun 2014 08:38:48 PM UTC, comment #5:

Attached patch checks for the name and then type.

(file #31589)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 20 Jun 2014 11:55:14 AM UTC, comment #4:

How about checking for "name" and then "type" keyword?

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 19 Jun 2014 09:10:08 PM UTC, comment #3:

A double click should open the file in the editor but this file is detected as a data file.
Looks like the line 268 in load-save.cc

detects the keyword "name" in the comment of the file.

Torsten <ttl>
Project Member
Thu 19 Jun 2014 05:14:43 PM UTC, comment #2:

It also does it 3.8.2rc1

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 19 Jun 2014 05:13:38 PM UTC, comment #1:

Does the same for me - only when file is opened from the file browser pane of the GUI by double click, or from the LoadData context menu.
Using the Open/Open File menus work as expected.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 19 Jun 2014 11:14:30 AM UTC, original submission:

The GUI gives an 'error : load: bogus identifier ' or ' nameerror: load: bogus identifier' if the script it reads in contains a variable definition and then a comment after it with the 'name' word in it.

Simple example attached. The error doesn't happen if you type the same line into the command window. The command line version does not have the same problem.

Solution for my example was to expand 'name' to 'filename' in the comment.

Chris Mumby <chrismumby>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31589:  bug42586.patch added by lostbard (1KiB - text/x-patch)
file #31581:  script.m added by chrismumby (91B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by chrismumby (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Jun 2014 08:36:33 PM UTClostbardStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 22 Jun 2014 11:24:20 AM UTClostbardStatusPatch Submitted=>Ready For Test
    Sat 21 Jun 2014 08:38:48 PM UTClostbardAttached File-=>Added bug42586.patch, #31589
      StatusNone=>Patch Submitted
      Assigned toNone=>lostbard
      Release3.8.1=>dev
      Operating SystemMicrosoft Windows=>Any
    Thu 19 Jun 2014 11:14:30 AM UTCchrismumbyAttached File-=>Added script.m, #31581

    Back to the top


    Powered by Savane 3.1-cleanup1