bugGNU Octave - Bugs: bug #42513, io: Some temporary variables in...

 
 

bug #42513: io: Some temporary variables in PKG_ADD are not cleaned up

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Thu 05 Jun 2014 12:54:09 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 12 Jul 2014 07:44:34 PM UTC, comment #3:

Pushed both to repo. (Took me a while to set things up here)

Thanks for the patches.
Closing report

Philip Nienhuis <philipnienhuis>
Project Member
Thu 05 Jun 2014 05:43:29 PM UTC, comment #2:

A changeset for converting PKD_{ADD,DEL} into Unix format is attached below. It applies AFTER the patch that I previously posted in the present bug report.

(file #31506)

Rafael Laboissiere <rlaboiss>
Thu 05 Jun 2014 05:12:43 PM UTC, comment #1:

What io package version?
Confirmed on my Linux box with io-2.2.2. cs looks good to me. Thank you for that + reporting.

As to the CRLF, I always clean them up manually (dos2unix) for all files (I mostly develop on Windows) but I may have overlooked it this time. Sorry about that.
That said, I often wonder where those CRLF EOLs come from anyway as TTBOMK neither Octave nor notepad++ produce them (notepad++ is instructed to leave EOLs as they are on all my boxes). I tried to hunt it down several times to no avail; I do the actual packaging on MinGW (MSYS CLI) which is no suspect either AFAIK.

As Carnë moved io over to mercurial (not quite my initiative) it'll be some time before I can fix it - svn was a breeze for me but currently I simply lack time to learn to properly manage mercurial at developer's level (contributing I think I can manage). Ah and my mercurial (=Linux distro) seems outdated as well.
Apart from this bug + the EOLs, the svn repo was ready for a 2.2.3 release (needed for octave 3.9.0+).

It would be nice if you could run the PKG* files thru dos2unix and produce a cs for that too- then maybe Carné can push all changesets.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 05 Jun 2014 12:54:09 PM UTC, original submission:

Some temporary variables (bnam, ooopath, and ii) defined in PKG_ADD are not cleaned up after execution. The changeset attached below fixes the problem.

Also, PLEASE, convert the files PKG_ADD and PKG_DEL from MSDOS format (CR/LF line terminators) into Unix (LF line terminators). Otherwise, it would be impossible to write patches for these files in the Debian package, for instance.

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31505:  clear-tmp-vars.patch added by rlaboiss (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 12 Jul 2014 07:44:34 PM UTCphilipnienhuisStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Thu 05 Jun 2014 05:43:29 PM UTCrlaboissAttached File-=>Added pkg-add-del-unix-format.patch, #31506
    Thu 05 Jun 2014 05:12:43 PM UTCphilipnienhuisStatusNone=>Patch Submitted
    Thu 05 Jun 2014 12:54:09 PM UTCrlaboissAttached File-=>Added clear-tmp-vars.patch, #31505

    Back to the top


    Powered by Savane 3.1-cleanup1