bugGNU nano - Bugs: bug #42374, Trunk SVN r4893: Cosmetic and...

 
 

bug #42374: Trunk SVN r4893: Cosmetic and miscellaneous fixes

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Fri 16 May 2014 03:31:11 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 16 May 2014 11:46:21 AM UTC, comment #1:

Both applied. Thanks.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 16 May 2014 03:31:11 AM UTC, original submission:

The attached two patches against trunk SVN r4893 do the following:

nano4893cosmetic.patch: Fixes a few whitespace inconsistencies; sets edit_refresh_needed to TRUE and FALSE instead of 1 and 0, for consistency with code elsewhere; and adds a comment indicating which Unicode character is used to tickle the terminal into displaying two-column characters properly.

nano4893misc.patch: Fixes two apparent oddities: in do_undo() and do_redo(), len should be size_t instead of int, in case of very long text lengths; and in do_gotoline_posx(), the edit_refresh() call made directly after edit_refresh_needed is set to TRUE is removed (in quick testing, text display still seems to work properly without it, but you might want to test it more to make sure).

Thanks in advance.

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31385:  nano4893cosmetic.patch added by dolorous (3KiB - application/octet-stream)
file #31386:  nano4893misc.patch added by dolorous (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 16 May 2014 11:46:21 AM UTCbensStatusNone=>Fixed
      Assigned toNone=>bens
      Open/ClosedOpen=>Closed
    Fri 16 May 2014 03:31:11 AM UTCdolorousAttached File-=>Added nano4893cosmetic.patch, #31385
      Attached File-=>Added nano4893misc.patch, #31386

    Back to the top


    Powered by Savane 3.1-cleanup1