bugGNU Octave - Bugs: bug #42334, datevec() output should have the...

 
 

bug #42334: datevec() output should have the same size as its input in case of datenum

Submitted by:  sergey plotnikov <nul0m>
Submitted on:  Sun 11 May 2014 07:10:55 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.8.1Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 12 May 2014 02:59:58 PM UTC, comment #3:

Yes, thanks for catching that. I checked in a fix for that (http://hg.savannah.gnu.org/hgweb/octave/rev/38925538ec14).

Rik <rik5>
Project Administrator
Mon 12 May 2014 12:33:55 PM UTC, comment #2:

Hm.. I believe there's a typo in the cset you've pushed. We should record the size of input if it is not a COLUMN vector.

sergey plotnikov <nul0m>
Mon 12 May 2014 12:17:03 AM UTC, comment #1:

I committed your patch with the addition of some input validation tests here: http://hg.savannah.gnu.org/hgweb/octave/rev/9eb72fa5f8b5. The fix was made on the development branch which will be released as version 4.2. You can build from Mercurial sources if you need the fix sooner. Thanks for contributing.

Rik <rik5>
Project Administrator
Sun 11 May 2014 07:10:55 PM UTC, original submission:

When input of datevec() function is datenum and nargout is greater than one all the output vectors should have the same size as input date. Below are the results comparing Matlab and Octave.

I hope the following patch would be a decent solution.

sergey plotnikov <nul0m>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31358:  datevec_size.patch added by nul0m (812B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by nul0m (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 12 May 2014 12:17:03 AM UTCrik5CategoryNone=>Octave Function
      StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 11 May 2014 07:10:55 PM UTCnul0mAttached File-=>Added datevec_size.patch, #31358

    Back to the top


    Powered by Savane 3.1-cleanup1