bugGNU Octave - Bugs: bug #42159, Inconsistent patch vertices/faces...

 
 

bug #42159: Inconsistent patch vertices/faces should lead to a warning

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Mon 21 Apr 2014 06:22:36 PM UTC  
 
Category: PlottingSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Jul 2014 05:36:42 PM UTC, comment #3:

I pushed the changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/df972b9d080a), after having verified all demos using patch objects returned the same images. Closing report.

Pantxo Diribarne <pantxo>
Project Member
Sat 21 Jun 2014 11:33:52 AM UTC, comment #2:

I attached an updated patch that corrects a bug when calling patch without argument.

(file #31586)

Pantxo Diribarne <pantxo>
Project Member
Sun 15 Jun 2014 02:56:09 PM UTC, comment #1:

I attached a patch. It is pretty huge for such a minor bug, but it brings patch graphics objects in line with other primitives (don't rely on .m listeners but rather on C++ updaters).

(file #31555)

Pantxo Diribarne <pantxo>
Project Member
Mon 21 Apr 2014 06:22:36 PM UTC, original submission:

In octave :

This is due to inconsistent vertices/faces properties. In Matlab it leads to a warning "Warning: Values in patch Faces must be in [1 : rows(Vertices)] - not rendering"

Contrary to all other base graphics objects, patch property updaters are implemented using listeners. This bug has an easy fix, but it would probably be more consistent to rewrite (translate) the listeners in the form of c++ updaters.

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31586:  listeners2updtaers_bug42159_v2.patch added by pantxo (17KiB - application/x-download)
file #31555:  listeners2updtaers_bug42159.patch added by pantxo (17KiB - application/x-download)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Updated the item)
  • -unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Jul 2014 05:36:42 PM UTCpantxoStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sat 21 Jun 2014 01:36:33 PM UTCbpabbottStatusNone=>Patch Submitted
    Sat 21 Jun 2014 11:33:52 AM UTCpantxoAttached File-=>Added listeners2updtaers_bug42159_v2.patch, #31586
    Sun 15 Jun 2014 02:56:09 PM UTCpantxoAttached File-=>Added listeners2updtaers_bug42159.patch, #31555

    Back to the top


    Powered by Savane 3.1-cleanup1