bugGNU nano - Bugs: bug #42140, Binding PageUp/PageDown to meta...

 
 

bug #42140: Binding PageUp/PageDown to meta keys makes Space and Minus stop working in the help viewer

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Fri 18 Apr 2014 11:57:54 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Apr 2014 08:47:21 PM UTC, comment #3:

First part is fixed now in SVN by r4810.
Second part was fixed by r4796.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 21 Apr 2014 09:47:55 AM UTC, comment #2:

Hi Chris,

Well, the problem is not that people would rebind "key_" but that they would rebind "k". Disallowing the latter would also disallow rebinding "kdel", which is something the sample nanorc suggests for fixing problems with the Backspace key. (Although I wonder: how is "bind kdel backspace all" different from "set rebinddelete"?)

Meanwhile I am considering also a different change: when the user has rebound ^Y and ^V, and has unbound all fucntion keys (which I normally do because I don't ever use them and don't want to see them shown anywhere), then the help lines show "kpup" and "kpdown". These abbreviations are unclear -- it would be much better if they would say "PgUp" and "PgDn", and similar for the other dedicated keys. And then maybe only allow "Delete" to be rebound, "bind Delete backspace all", if this really is different form rebinddelete.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sat 19 Apr 2014 02:21:02 PM UTC, comment #1:

Hey Benno,

Don't just be tempted to do that assignment, do it. As far as Im concerned KEY_PPAGE and KEY_NPAGE are ncurses macros only and should not be rebindable. We can add error messages when people try to rebind key_* but your workaround sounds fine.

Chris Allegretta <astyanax>
Project Administrator
Fri 18 Apr 2014 11:57:54 AM UTC, original submission:

When unbinding ^Y and ^V for the menu help, and then rebinding the pageup and pagedown functions to say M-U and M-N, this will make the Space and Minus compatibility keys in the help viewer (and also in the file browser when the undinding and rebinding is done for all menus) stop working. This is because in the translation from space/minus via a corresponding shortcut to a corresponding other key sequence, the boolean meta_key doesn't get set although in these cases this would actually be required.

I am tempted to set in parse_help_input()/parse_browser_input() *kbinput simply to KEY_PPAGE/KEY_NPAGE, but nano allows even these keys to be rebound. Argh.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by astyanax (Posted a comment)
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Apr 2014 08:47:21 PM UTCbensStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 21 Apr 2014 09:47:55 AM UTCbensAssigned toNone=>bens
      SummaryBinding PageUp/PageDown to meta keys make Space and Minus stop working in the help viewer=>Binding PageUp/PageDown to meta keys makes Space and Minus stop working in the help viewer

    Back to the top


    Powered by Savane 3.1-cleanup1