bugGNU Octave - Bugs: bug #41984, Package Image 2.2.1 (imsmooth)-...

 
 

bug #41984: Package Image 2.2.1 (imsmooth)- bug into the Bilateral filter

Submitted by:  Marc Vivet <marcvivet>
Submitted on:  Thu 27 Mar 2014 10:54:16 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Inaccurate Result
Status: FixedAssigned to: None
Originator Name: Marc VivetOpen/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Mar 2015 12:14:51 AM UTC, comment #4:

Awesome. Thank you for the patch. I have pushed as http://hg.code.sf.net/p/octave/image/rev/6a8da9c2a391

Carnë Draug <carandraug>
Project Member
Sun 22 Mar 2015 06:59:24 PM UTC, comment #3:

Bug fix + test for bilateral filter attached.

(file #33420)

Avinoam Kalma <avinoam>
Project Member
Thu 19 Mar 2015 11:06:47 PM UTC, comment #2:

Could you add a test for imsmooth on your cset as well? I will then push this.

Carnë Draug <carandraug>
Project Member
Thu 19 Mar 2015 08:30:15 PM UTC, comment #1:

The problem is in line 71 of __bilateral__.cc: val[i] should im(r+s,c+s,i).

changeset attached.

(file #33401)

Avinoam Kalma <avinoam>
Project Member
Thu 27 Mar 2014 10:54:16 PM UTC, original submission:

When using the function imsmooth configured to perform a Bilateral filter, results in a shifted image.

For instance:

ima_out = imsmooth(ima_in, 'Bilateral', 2, 10);

where ima_in is the input image, 2 is the spatial sigma and 10 is the range sigma.

This causes that ima_out is not aligned to ima_in.

The problem seems to be caused by the file _bilateral_.cc and the amount of shift is proportinal to the spatial sigma for the X and Y axis.

It can be computed as <spatial sigma>*3 on the X and Y axes.

Marc Vivet <marcvivet>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33420:  bilateral2.patch added by avinoam (2KiB - application/octet-stream)
file #33401:  bilateral.patch added by avinoam (818B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Updated the item)
  • -unavailable- added by marcvivet (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 26 Mar 2015 12:14:51 AM UTCcarandraugOpen/ClosedOpen=>Closed
      Operating SystemMicrosoft Windows=>Any
    Thu 26 Mar 2015 12:14:50 AM UTCcarandraugStatusNone=>Fixed
    Sun 22 Mar 2015 06:59:24 PM UTCavinoamAttached File-=>Added bilateral2.patch, #33420
    Thu 19 Mar 2015 11:06:47 PM UTCcarandraugRelease3.8.1=>other
    Thu 19 Mar 2015 08:30:15 PM UTCavinoamAttached File-=>Added bilateral.patch, #33401

    Back to the top


    Powered by Savane 3.1-cleanup1