bugGNU FreeIPMI - Bugs: bug #41903, interpret/ipmi-interpret.c: 3 *...

 
 

bug #41903: interpret/ipmi-interpret.c: 3 * leap before look ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Wed 19 Mar 2014 08:37:48 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Operating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 19 Mar 2014 03:38:08 PM UTC, comment #1:

you're absolutely right, thanks for the catch. It's been fixed and it'll be in the next release. Credit for your catch is in the ChangeLog.

Albert Chu <chu11>
Project Administrator
Wed 19 Mar 2014 08:37:48 AM UTC, original submission:

1.

[interpret/ipmi-interpret.c:513]: (style) Array index 'i' is used before limits check.

Source code is

while (sel_config[i]
&& i < offset_from_event_reading_type_code
&& i < IPMI_INTERPRET_MAX_SENSOR_AND_EVENT_OFFSET)

Maybe

while (i < offset_from_event_reading_type_code
&& i < IPMI_INTERPRET_MAX_SENSOR_AND_EVENT_OFFSET
&& sel_config[i])

might be better code.

2.

[interpret/ipmi-interpret.c:1028]: (style) Array index 'i' is used before limits check.

3.

[interpret/ipmi-interpret.c:1131]: (style) Array index 'i' is used before limits check.

Duplicates.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chu11 (Posted a comment)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 19 Mar 2014 03:38:17 PM UTCchu11Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1