(
Jump to the original submission)
Mon 07 Apr 2014 10:14:29 AM UTC, comment #7:
Did not spend time in doing this for long. Sorry.
Anyway will try to write test case. Thanks :).
|
Sun 06 Apr 2014 09:27:43 PM UTC, comment #6:
I went ahead and changed the initialization value to Octave_NaN and committed your patch here (http://hg.savannah.gnu.org/hgweb/octave/rev/cb37b17b6091). Closing report.
|
Fri 14 Mar 2014 04:11:35 PM UTC, comment #5:
Okay I will change it to Octave_NaN.
I have not written any test case for Octave so far. I will give it a try.
|
Thu 13 Mar 2014 11:01:08 PM UTC, comment #4:
I think it might be better to initialize with Octave_NaN. A return value of Octave_Inf would imply that the calculation succeeded, but that the result was Inf. A return value of NaN usually indicates a major failure.
Second, it's not required but it would be nice to demonstrate a test case where this matters.
|
Fri 07 Mar 2014 05:47:11 PM UTC, comment #3:
Messed up folding. So created a new patch and attached it here. Please have a look at it.
(file #30823)
|
Fri 07 Mar 2014 04:41:25 PM UTC, comment #2:
Can you please fold all of these patches into one? Enable the histedit
extension and do
then in the plan that shows up in your text editor, pick "fold" for the
relevant patches.
|
Fri 07 Mar 2014 04:39:25 PM UTC, comment #1:
Can you please fold all of these patches into one? Enable the histedit extension and do
|
Fri 07 Mar 2014 04:09:11 PM UTC, original submission:
rcond() function was returning uninitialised values in some error condition. Initialised the value to octave_Inf.
Questions:
1. Is returning octave_Inf correct in this case? If not what is the correct return value?
2. Is there a need to add test cases for rcond that check failure cases also?
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 9 latest changes.
| Date |
Changed By |
Updated Field |
Previous Value |
=> |
Replaced By |
| Sun 06 Apr 2014 09:27:43 PM UTC | rik5 | Status | Patch Submitted |  | Fixed |
| | | Open/Closed | Open |  | Closed |
| | | Summary | Fix returning uninitialised value |  | Fix rcond returning uninitialised value |
| Fri 07 Mar 2014 05:47:11 PM UTC | prasannatsm | Attached File | - |  | Added fix_uninitialised_return_values.diff, #30823 |
| Fri 07 Mar 2014 04:39:25 PM UTC | jordigh | Status | None |  | Patch Submitted |
| Fri 07 Mar 2014 04:09:11 PM UTC | prasannatsm | Attached File | - |  | Added fix_uninitialised_return_in_dMatrixcc.diff, #30818 |
| | | Attached File | - |  | Added fix_uninitialised_return_in_fMatrixcc.diff, #30819 |
| | | Attached File | - |  | Added fix_uninitialised_return_in_CMatrixcc.diff, #30820 |
| | | Attached File | - |  | Added fix_uninitialised_return_in_fCMatrixcc.diff, #30821 |