bugGNU Octave - Bugs: bug #41531, isequaln fails comparing object to...

 
 

bug #41531: isequaln fails comparing object to non-object

Submitted by:  Felipe G. Nievinski <fgnievinski>
Submitted on:  Sun 09 Feb 2014 07:37:18 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.8.0Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 12 Feb 2014 05:12:58 PM UTC, comment #3:

I made a few modifications. The Octave coding convention is to surround the conditional of an if statement in parentheses as for C/C++. I also broke out of the for loop immediately with break rather than continue; Once we know one of the inputs is not an object it will be impossible for isequal to return true. The changeset is here (http://hg.savannah.gnu.org/hgweb/octave/rev/ff7e7928f160) on the stable branch.

Rik <rik5>
Project Administrator
Mon 10 Feb 2014 03:02:54 PM UTC, comment #2:

here you go

(file #30496)

Felipe G. Nievinski <fgnievinski>
Mon 10 Feb 2014 03:52:54 AM UTC, comment #1:

Could you prepare a Mercurial changeset or a unified diff? I can't apply the attached diff with patch because it doesn't have any context.

Rik <rik5>
Project Administrator
Sun 09 Feb 2014 07:37:18 PM UTC, original submission:

patch attached

Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30496:  isequal.patch added by fgnievinski (963B - application/octet-stream)
file #30493:  __isequal__.m.diff added by fgnievinski (314B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by fgnievinski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 12 Feb 2014 05:12:58 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 10 Feb 2014 03:02:54 PM UTCfgnievinskiAttached File-=>Added isequal.patch, #30496
    Sun 09 Feb 2014 07:37:18 PM UTCfgnievinskiAttached File-=>Added _isequal_.m.diff, #30493

    Back to the top


    Powered by Savane 3.1-cleanup1