bugmake - Bugs: bug #40789, GNU make 4.0 includes...

 
 

bug #40789: GNU make 4.0 includes <dlfcn.h> in commands.c when not required

Submitted by:  Alan Hourihane <alanh>
Submitted on:  Tue 03 Dec 2013 03:10:00 PM UTC  
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  Paul D. Smith <psmith> Open/Closed:  Closed
Component Version:  4.0 Operating System:  None
Fixed Release:  4.1 Triage Status:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 12 Jan 2014 05:16:12 AM UTC, comment #1: 

I've removed that header file.  Thanks!

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 03 Dec 2013 03:10:00 PM UTC, original submission:  

There's an extra line in commands.c that does...

#include <dlfcn.h>

This is not used in this file, and can be removed.

But it also causes build problems on platforms that don't have dlfcn.h as well.

The code in load.c correctly wraps dlfcn.h because of the test and use of MAKE_LOAD.

Therefore the one in commands.c can be removed.

Alan Hourihane <alanh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by alanh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-12 psmith Item GroupNone => Bug
        StatusNone => Fixed
        Assigned toNone => psmith
        Open/ClosedOpen => Closed
        Component VersionNone => 4.0
        Fixed ReleaseNone => 4.1

    Back to the top


    Powered by Savane 3.6