bugGNU Octave - Bugs: bug #40770, specfun package: Si Function is...

 
 

bug #40770: specfun package: Si Function is slow and flaky

Submitted by:  None
Submitted on:  Sun 01 Dec 2013 05:39:21 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Performance
Status: NoneAssigned to: None
Originator Name: Bastiaan ZapfOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 3.2.4
Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 02 Dec 2013 08:57:46 PM UTC, comment #3:

Closing as it was open a new one on the patch tracker. For future reference, see https://savannah.gnu.org/patch/index.php?8250

Carnë Draug <carandraug>
Project Member
Mon 02 Dec 2013 05:27:57 PM UTC, comment #2:

I'm guessing this a replacement for the Si function in the specfun package and not gsl since it still bears the copyright for that file. It's actually bad that SI is implemented (most likely differently) in two different packages (but that will be fixed soon).

If this is a patch for the specfun package: the Si function has been deprecated and replaced by sinint. Could you please provide us with a patch against the development version of sinint

https://sourceforge.net/p/octave/specfun/ci/default/tree/inst/sinint.m

If this is a patch for the gsl package: the gsl package aims at being a wrapper for the GSL library. This a m file and not compatible with it, and therefore not acceptable.

Anyway, whether the correct place would be the patch or bug tracker but there is no need to go and open a new entry for it now.

Carnë Draug <carandraug>
Project Member
Sun 01 Dec 2013 08:21:26 PM UTC, comment #1:

Si is a function from the Octave-Forge gsl package:

As your contribution doesn't fix a bug, please upload your patch to the patch tracker, https://savannah.gnu.org/patch/?group=octave
and in the subject line clearly mention that is is for the OF gsl package, perhaps like so:
"OF gsl package: improve performance of Si.m"

Note that the gsl package hasn't received much attention the last years, the last release is from 2009. I think we need someone who actively works with it to pick up its maintenance.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 01 Dec 2013 05:39:21 PM UTC, original submission:

The Si Function is rather slow, and it produces spurious values.

> plot(Si(-100:0.1:100))
> plot(real(Si(-100:0.1:100)))


(shows complex components)

> plot(Si(0:0.3:400))


(what?)

The attached file improves Performance and is correct over all reals. It contains the old implementation to treat complex cases.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29751:  Si.m added by None (4KiB - text/x-objcsrc - (not a patch, rather a whole file))

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 02 Dec 2013 08:57:46 PM UTCcarandraugOpen/ClosedOpen=>Closed
      Dependencies-=>Depends on patch #8250
    Mon 02 Dec 2013 05:27:57 PM UTCcarandraugSummarySi Function is slow and flaky=>specfun package: Si Function is slow and flaky
    Sun 01 Dec 2013 08:21:26 PM UTCphilipnienhuisCategoryOctave Function=>Octave Forge Package
    Sun 01 Dec 2013 05:39:21 PM UTCNoneAttached File-=>Added Si.m, #29751

    Back to the top


    Powered by Savane 3.1-cleanup1