bugGNU Octave - Bugs: bug #40770, specfun package: Si Function is...

 
 

bug #40770: specfun package: Si Function is slow and flaky

Submitter:  None
Submitted:  Sun 01 Dec 2013 05:39:21 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Performance
Status:  None Assigned to:  None
Originator Name:  Bastiaan Zapf Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 3.2.4
Operating System:  * GNU/Linux Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 02 Dec 2013 08:57:46 PM UTC, comment #3: 

Closing as it was open a new one on the patch tracker. For future reference, see https://savannah.gnu.org/patch/index.php?8250

Carnë Draug <carandraug>
Group Member
Mon 02 Dec 2013 05:27:57 PM UTC, comment #2: 

I'm guessing this a replacement for the Si function in the specfun package and not gsl since it still bears the copyright for that file. It's actually bad that SI is implemented (most likely differently) in two different packages (but that will be fixed soon).

If this is a patch for the specfun package: the Si function has been deprecated and replaced by sinint. Could you please provide us with a patch against the development version of sinint

https://sourceforge.net/p/octave/specfun/ci/default/tree/inst/sinint.m

If this is a patch for the gsl package: the gsl package aims at being a wrapper for the GSL library. This a m file and not compatible with it, and therefore not acceptable.

Anyway, whether the correct place would be the patch or bug tracker but there is no need to go and open a new entry for it now.

Carnë Draug <carandraug>
Group Member
Sun 01 Dec 2013 08:21:26 PM UTC, comment #1: 

Si is a function from the Octave-Forge gsl package:

octave-3.2.4.exe:1> which Si
`Si' is a function from the file C:\Programs\Octave\3.2.4_gcc-4.4.0\libexec\octave\package
s\gsl-1.0.8\i686-pc-mingw32-api-v37\gsl_sf.oct


As your contribution doesn't fix a bug, please upload your patch to the patch tracker, https://savannah.gnu.org/patch/?group=octave
and in the subject line clearly mention that is is for the OF gsl package, perhaps like so:
"OF gsl package: improve performance of Si.m"

Note that the gsl package hasn't received much attention the last years, the last release is from 2009. I think we need someone who actively works with it to pick up its maintenance.

Philip Nienhuis <philipnienhuis>
Group Member
Sun 01 Dec 2013 05:39:21 PM UTC, original submission:  


The Si Function is rather slow, and it produces spurious values.

> plot(Si(-100:0.1:100))
> plot(real(Si(-100:0.1:100)))


(shows complex components)

> plot(Si(0:0.3:400))


(what?)

The attached file improves Performance and is correct over all reals. It contains the old implementation to treat complex cases.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29751:  Si.m added by None (4KiB - text/x-objcsrc - (not a patch, rather a whole file))

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-12-02 carandraug Open/ClosedOpen Closed
        Dependencies- Depends on patch #8250
    2013-12-02 carandraug SummarySi Function is slow and flaky specfun package: Si Function is slow and flaky
    2013-12-01 philipnienhuis CategoryOctave Function Octave Package
    2013-12-01 None Attached File- Added Si.m, #29751

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code