bugDDD - Bugs: bug #40701, layout.C: 2 * bad if test ?

 
 

bug #40701: layout.C: 2 * bad if test ?

Submitter:  David Binderman <dcb314>
Submitted:  Mon 25 Nov 2013 03:08:31 PM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 28 Dec 2022 11:21:01 AM UTC, comment #1: 

fixed

Stefan Eickeler <eickeler>
Project Administrator
Mon 25 Nov 2013 03:08:31 PM UTC, original submission:  

I just ran the static analyser cppcheck over the source
code of ddd-3.3.12. It said

1.

[layout.C:1338] -> [layout.C:1338]: (style) Same expression on both sides of '&&'.

Source code is

    if (node->hashprev && node->hashprev) {
    node->hashprev->hashnext = node->hashnext;
    node->hashnext->hashprev = node->hashprev;

I think

    if (node->hashprev && node->hashnext) {
    node->hashprev->hashnext = node->hashnext;
    node->hashnext->hashprev = node->hashprev;

might be better code.

2.

[layout.C:1796] -> [layout.C:1796]: (style) Same expression on both sides of '&&'.

    if (graph->hashprev && graph->hashprev) {
    graph->hashprev->hashnext = graph->hashnext;
    graph->hashnext->hashprev = graph->hashprev;

Duplicate.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eickeler (Posted a comment)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-12-28 eickeler StatusNone Fixed
    2022-12-28 eickeler Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.9