bugGNU Octave - Bugs: bug #40534, Fix null pointer access in...

 
 

bug #40534: Fix null pointer access in octave_fcn_binder::maybe_binder

Submitted by:  PrasannaKumar Muralidharan <prasannatsm>
Submitted on:  Sun 10 Nov 2013 10:18:20 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 11 Nov 2013 08:13:00 AM UTC, comment #4:

Okay. Will do.

PrasannaKumar Muralidharan <prasannatsm>
Mon 11 Nov 2013 06:57:20 AM UTC, comment #3:

We also avoid using NULL in C++ code. I checked in another changeset to fix that in ov-fcn-handle.cc and a few other files.

Unless there is some ambiguity, the filenames in the log entries don't need to include the full directory name. But we normally do include the class name as part of the function name. And there should be a space between the file name and the function name. So you should write

instead of

John W. Eaton <jwe>
Project Administrator
Mon 11 Nov 2013 05:43:04 AM UTC, comment #2:

Thanks for accepting the patch :). Will follow the GNU style.

PrasannaKumar Muralidharan <prasannatsm>
Sun 10 Nov 2013 11:13:48 PM UTC, comment #1:

Thanks for the Mercurial changeset. That format makes it easy to apply by the maintainers. I added it to Octave here (http://hg.savannah.gnu.org/hgweb/octave/rev/f05f571ff1fa). I changed the commit message a bit to reflect the GNU style which we use. The first line is a general description of what was done in the commit (I just key what you wrote). Then, for every file we list the file, the function affected in parentheses, and then what was actually modified in the code.

We also use the GNU style for code indentation with line lengths < 80 characters. I took a word out of a comment line so that it would fit under 80 characters.

This will be a part of the 3.8.0 release which is due out very soon.

Rik <rik5>
Project Administrator
Sun 10 Nov 2013 10:18:20 AM UTC, original submission:

Fixed null pointer access in octave_fcn_binder::maybe_binder function.

PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by prasannatsm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 10 Nov 2013 11:13:48 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 10 Nov 2013 10:18:21 AM UTCprasannatsmAttached File-=>Added fix_nullpointer_access.diff, #29582

    Back to the top


    Powered by Savane 3.1-cleanup1