bugGNU gettext - Bugs: bug #40528, gettext-0.18.3.1: 3 * bad if tests...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #40528: gettext-0.18.3.1: 3 * bad if tests ?

Submitter:  David Binderman <dcb314>
Submitted:  Sat 09 Nov 2013 10:54:48 AM UTC
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  ueno
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Mon 11 Nov 2013 08:58:54 AM UTC, comment #1: 
Daiki Ueno <ueno>
Project Administrator
Sat 09 Nov 2013 10:54:48 AM UTC, original submission:  

I just compiled gettext-0.18.3.1 with extra gcc compiler
flag -Wlogical-op

It said

x-c.c:1174:15: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
x-perl.c:1088:19: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
x-vala.c:718:19: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

I checked them all and they look like || should be replaced by &&.
I also checked the current source code and the bugs also appear
there.

You may wish to add compiler flag -Wlogical-op to your development
builds.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Updated the item)
  • -email is unavailable- added by ueno (Posted a comment)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-27 haible CategoryNone Build
        Assigned toNone ueno
    2013-11-11 ueno StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top


    Powered by Savane 3.9