bugGNU gettext - Bugs: bug #40528, gettext-0.18.3.1: 3 * bad if tests...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #40528: gettext-0.18.3.1: 3 * bad if tests ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Sat 09 Nov 2013 10:54:48 AM UTC  
 
Category: BuildSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Daiki Ueno <ueno>
Open/Closed: Closed

Mon 11 Nov 2013 08:58:54 AM UTC, comment #1:

Thanks for spotting this. Fixed in the git:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?h=maint&id=814f1e1251c076acd7a468add23a5354aad3dd60

Daiki Ueno <ueno>
Project AdministratorIn charge of this item.
Sat 09 Nov 2013 10:54:48 AM UTC, original submission:

I just compiled gettext-0.18.3.1 with extra gcc compiler
flag -Wlogical-op

It said

x-c.c:1174:15: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
x-perl.c:1088:19: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
x-vala.c:718:19: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

I checked them all and they look like || should be replaced by &&.
I also checked the current source code and the bugs also appear
there.

You may wish to add compiler flag -Wlogical-op to your development
builds.

David Binderman <dcb314>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by haible (Updated the item)
  • -unavailable- added by ueno (Posted a comment)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 27 Nov 2016 01:54:46 AM UTChaibleCategoryNone=>Build
      Assigned toNone=>ueno
    Mon 11 Nov 2013 08:58:54 AM UTCuenoStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1