bugGNU Octave - Bugs: bug #40490, io 1.2.4: odsread yields errors if...

 
 

bug #40490: io 1.2.4: odsread yields errors if filename is too short

Submitted by:  Sébastien Villemot <svillemot>
Submitted on:  Wed 06 Nov 2013 02:21:59 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Philip Nienhuis <philipnienhuis>
Originator Name: Open/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 08 Nov 2013 04:33:02 PM UTC, comment #3:

Maybe already this weekend I'll make an io-1.2.5 release

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 06 Nov 2013 09:20:10 PM UTC, comment #2:

Confirmed.
The code was copied from the excel side, where fileparts() would not easily catch all cases, and had a special extension test order to avoid exactly this bug.

But funny that my test scripts didn't catch it.

Markus informed me of yet another bug.

Then there is the issue of a buggy unpack.m in core 3.6.4 (see bug #39148) hampering .xlsx OCT support in Octave 3.6.x.
Could be fixed by including the fixed unpack.m from the dev version in the io inst/ subdir.

There may be an io-1.2.5 soon, to cater for staunch 3.6.x users.
But I'll await more bug reports for a little while.

BTW some devs around here would call this an incorrect result rather than a crash - AFAIU the latter is reserved for cases where Octave itself is going down ==> title adapted=> regression (as it used to work OK)

Thanks for reporting

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 06 Nov 2013 02:54:13 PM UTC, comment #1:

I think this should be rewritten with function "fileparts". Something like:

Andreas Weber <andy1978>
Project Member
Wed 06 Nov 2013 02:21:59 PM UTC, original submission:

In io 1.2.4, if one runs odsread on a short filename (e.g. on "test.ods"), then odsopen.m crashes at the following line (244):

This test assumes that filename is at least of length 9. It should be changed to something like:

Sébastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by carandraug (PhilipNienhuis (maintainer of the IO package))
  • -unavailable- added by andy1978 (Posted a comment)
  • -unavailable- added by svillemot (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Nov 2013 04:33:02 PM UTCphilipnienhuisStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Wed 06 Nov 2013 09:20:10 PM UTCphilipnienhuisItem GroupSegfault, Bus Error, etc.=>Regression
      StatusNone=>Confirmed
      Assigned toNone=>philipnienhuis
      Operating SystemGNU/Linux=>Any
      Summaryio 1.2.4: odsread crashes if filename is short=>io 1.2.4: odsread yields errors if filename is too short
    Wed 06 Nov 2013 05:04:30 PM UTCcarandraugCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1