bugPSPP - Bugs: bug #40375, pspp-0.8.1: 3 * bad if tests ?

 
 

bug #40375: pspp-0.8.1: 3 * bad if tests ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Fri 25 Oct 2013 06:29:55 PM UTC  
 
Category: NoneSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: Future
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 25 Oct 2013 07:09:53 PM UTC, comment #1:

I think you are right. I fixed these.
Thanks for the report.

John Darrington <jmd>
Project Administrator
Fri 25 Oct 2013 06:29:55 PM UTC, original submission:

I just compiled pspp-0.8.1 with Linux gcc extra flag -Wlogical-op

It said

./src/language/lexer/q2c.c:1732:2: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]
src/data/data-in.c:922:3: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
src/language/stats/glm.c:270:4: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

I've checked all three and they look like && || mixups to me
Suggest code rework.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 25 Oct 2013 07:09:53 PM UTCjmdStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      ReleaseNone=>Future

    Back to the top


    Powered by Savane 3.1-cleanup1