bugGNU Octave - Bugs: bug #40367, <pre> tag visible when using...

 
 

bug #40367: <pre> tag visible when using command line news

Submitted by:  Rik <rik5>
Submitted on:  Fri 25 Oct 2013 01:48:30 AM UTC  
 
Category: GUISeverity: 2 - Minor
Priority: 5 - NormalItem Group: Documentation
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 26 Oct 2013 04:42:56 AM UTC, comment #4:

Ok, good idea, I incorporated that into this change and pushed

http://hg.savannah.gnu.org/hgweb/octave/rev/811b5a562680

Sorry for the delay.

Mike Miller <mtmiller>
Project Administrator
Fri 25 Oct 2013 01:22:24 PM UTC, comment #3:

Mike, that change looks good to me. You might want to also put an error message in the window if the file can't be opened or if it is empty so that there will be some clue about what happened. If you don't have time to do that, then let me know and I will after you push your change to savannah.

Thanks!

John W. Eaton <jwe>
Project Administrator
Fri 25 Oct 2013 01:12:16 PM UTC, comment #2:

It doesn't have to be a URL. The function that takes URL is only used in that one place. Attached changeset works for me, merges those two functions and reads from a file instead of a URL. There's probably a Qt way to read a URL into a string but this works for NEWS as a local file.

(file #29467)

Mike Miller <mtmiller>
Project Administrator
Fri 25 Oct 2013 04:28:03 AM UTC, comment #1:

I think the GUI just uses a file:/// URL, so no, it might not be so simple as just wrappeing in <pre> and </pre> tags, but we can certainly do something better.

John W. Eaton <jwe>
Project Administrator
Fri 25 Oct 2013 01:48:30 AM UTC, original submission:

In the CLI version of Octave, typing 'news', brings up the NEWS file which is now wrapped in

tags. This isn't horrible. Still, it might be better to leave NEWS as a plain text file and wrap the pre tags around the text in news in the GUI. I presume the GUI reads the file in as a string so it would be too hard to prepend, append the tags and then pass that text to the HTML viewer.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29467:  news.diff added by mtmiller (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 26 Oct 2013 04:42:56 AM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 25 Oct 2013 01:12:16 PM UTCmtmillerAttached File-=>Added news.diff, #29467
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1