(
Jump to the original submission)
Sat 02 Nov 2013 06:47:36 PM UTC, comment #6:
Forgot about this one for a few days. Fixed in the following changeset:
http://hg.savannah.gnu.org/hgweb/octave/rev/c2d9d42f4fe1
|
Wed 30 Oct 2013 01:33:44 AM UTC, comment #5:
I only see do_which being called from dbstatus and _which_, so AFAICT it's safe, at least nothing else in Octave is expecting a relative path.
The Matlab help at
http://www.mathworks.com/help/matlab/ref/which.html
says that it always returns a full path.
|
Tue 29 Oct 2013 03:52:14 AM UTC, comment #4:
Mike, your change seems fine to me as long as there aren't times when this function is expected to return relative file names.
|
Tue 29 Oct 2013 03:19:40 AM UTC, comment #3:
How about the attached change fixing it at a slightly lower level instead?
I see you updated the docstring as well. The new paragraph you added is a little unclear, it seems to imply that which only works for function files (m-files), but it also works with arbitrary files of any type, as well as built-in functions and functions in oct-files.
(file #29497)
|
Tue 22 Oct 2013 12:16:55 PM UTC, comment #2:
I've now uploaded a revised patch which also adds help for the function call syntax.
|
Tue 22 Oct 2013 11:50:56 AM UTC, comment #1:
Ignore the first patch, there are mistakes in it, I'm working on an improvement.
|
Mon 21 Oct 2013 07:07:54 PM UTC, original submission:
'which mfile.m' returns a relative path to the file when that file is in the current directory. In Matlab this is always an absolute path.
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 7 latest changes.
| Date |
Changed By |
Updated Field |
Previous Value |
=> |
Replaced By |
| Sat 02 Nov 2013 06:47:36 PM UTC | mtmiller | Status | Patch Submitted |  | Fixed |
| | | Open/Closed | Open |  | Closed |
| Wed 30 Oct 2013 02:09:32 AM UTC | mtmiller | Assigned to | None |  | mtmiller |
| Tue 29 Oct 2013 03:19:40 AM UTC | mtmiller | Attached File | - |  | Added bug40332.diff, #29497 |
| Tue 22 Oct 2013 12:15:53 PM UTC | crobar | Attached File | - |  | Added which_canon_path.patch, #29441 |
| Tue 22 Oct 2013 11:38:53 AM UTC | jwe | Status | None |  | Patch Submitted |
| Tue 22 Oct 2013 11:01:27 AM UTC | crobar | Attached File | - |  | Added which_canon_path.patch, #29440 |