bugGNU Octave - Bugs: bug #40222, OF windows pkg doesn't get...

 
 

bug #40222: OF windows pkg doesn't get installed anymore with Octave dev version

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Wed 09 Oct 2013 05:30:50 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 18 Oct 2013 04:51:36 PM UTC, comment #9:

Pushed:
http://hg.savannah.gnu.org/hgweb/octave/rev/3d862202c4f6

Philip Nienhuis <philipnienhuis>
Project Member
Fri 18 Oct 2013 11:46:26 AM UTC, comment #8:

Looks good to me, if that fixes the error you're seeing, and it looks to me like it should, go ahead and push it.

Mike Miller <mtmiller>
Project Administrator
Fri 18 Oct 2013 10:03:38 AM UTC, comment #7:

OK here's a changeset w/o include guards.

(file #29398)

Philip Nienhuis <philipnienhuis>
Project Member
Sat 12 Oct 2013 07:55:11 PM UTC, comment #6:

There's no need to check for an include guard, just include <string>. I think this is an appropriate fix, as long as you make that change.

Mike Miller <mtmiller>
Project Administrator
Sat 12 Oct 2013 07:46:20 PM UTC, comment #5:

Attached is a changeset for version.in.h

Using this patch the OF windows package can be installed fine (tried on my two Windows boxes.)

An obvious question is whether this is the appropriate fix:

- Is it version.h's "fault" to blindly rely on <string.h>?

- Or should configure in the OF windows package be amended? (so far I've only encountered problems with the windows package, but I have only tried 10 or so OF packages.)

Note that with current MXE Windows build, without this fix the src/build_packages.m script will fail building the windows package.

(file #29363)

Philip Nienhuis <philipnienhuis>
Project Member
Wed 09 Oct 2013 06:57:54 PM UTC, comment #4:

Indeed, after inserting

#include <string>

at the top of OCTAVE_HOME>/include/octave-3.7.7+/octave/version.h, the windows package gets installed fine.

Could the cure be to do something like

#ifndef STRING_H
#include <string>
#endif

in version.in.h ?

Philip Nienhuis <philipnienhuis>
Project Member
Wed 09 Oct 2013 05:58:09 PM UTC, comment #3:

Yes, that's the one.

Michael Goffioul <goffioul>
Project Member
Wed 09 Oct 2013 05:46:02 PM UTC, comment #2:

Could it be related to changeset 17510:7542f4496974 ?

Some configure error messages apply to statements in version.in.h that have changed in the above mentioned changeset

Philip Nienhuis <philipnienhuis>
Project Member
Wed 09 Oct 2013 05:45:08 PM UTC, comment #1:

The problem is that now <version.h> generated by octave is using std::string (it wasn't before), but it doesn't include <string>. So at the moment, if you want to include <version.h>, you need to include <string> before it.

I think <version.h> should include <string> itself.

Michael Goffioul <goffioul>
Project Member
Wed 09 Oct 2013 05:30:50 PM UTC, original submission:

See (parts of) the discussion about this in bug #40180.

While many other OF packages install w/o issues, (e.g., control, io, general, ...), the windows package can't get beyond the configure step. This issue popped up about a week ago.

(Above lines may not be in strict chronological order as there are separate processes at work).

Manually trying the various commands in share/.../pkg/private/configure_make.m in an MSYS shell, I can only get as far as a complaint from configure a la "mkoctfile not found". But that doesn't match the error messages above => I gave up there.

Note that in lines 51-65 of configure_make.m, where the configure flags are cooked, 'mkoctfile ("-p", "AR")' always returns newlines at the end, e.g.:

(note CRLF at end); these newlines end up in the final shell command a few lines down.
To my surprise this also happens on older (e.g., 3.7.5) Octave versions; apparently that wasn't a problem there ?!

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29398:  version.in.h.2.cs added by philipnienhuis (647B - text/x-csharp)
file #29363:  version.in.h.cs added by philipnienhuis (695B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by goffioul (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 18 Oct 2013 04:51:36 PM UTCphilipnienhuisStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 18 Oct 2013 10:03:38 AM UTCphilipnienhuisAttached File-=>Added version.in.h.2.cs, #29398
    Sat 12 Oct 2013 07:55:11 PM UTCmtmillerStatusNone=>Patch Submitted
    Sat 12 Oct 2013 07:46:20 PM UTCphilipnienhuisAttached File-=>Added version.in.h.cs, #29363

    Back to the top


    Powered by Savane 3.1-cleanup1