bugDenemo - Bugs: bug #40216, OBS patch for 1.0.8

 
 

bug #40216: OBS patch for 1.0.8

Submitted by:  None
Submitted on:  Wed 09 Oct 2013 12:31:59 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 10 Oct 2013 09:06:49 AM UTC, comment #6:

The one which should have been void was the recursive one - it does a return of a call to itself, but just for the side effect on the argument, not to return a value. My fault entirely.

Richard Shann <rshann>
Project Administrator
Thu 10 Oct 2013 08:33:13 AM UTC, comment #5:

If a function had no return at all, I changed it to void, otherwise added return 0; to all "exit paths" of that function. Looking at the patch i can't find where I should have added a return to a otherwise void function... anyway I think you can close this ticket now, thanks

Anonymous
Wed 09 Oct 2013 05:15:33 PM UTC, comment #4:

Ah, I see. I have been through all the static function declarations now - quite a few should have been void.
There was only one function where you added return statements I think - corect me if I'm wrong - it should in fact also have been a void function. All now in git.
Thank you!

Richard Shann <rshann>
Project Administrator
Wed 09 Oct 2013 03:30:18 PM UTC, comment #3:

It isn't only about whitespace, mostly, honestly I don't understand why there are changes to whitespace at all, I didn't touch those lines... I had to change quite some static function definitions to return void, not gint, and add return values where the function was defined to do so but some else branch only had "return;"

Anonymous
Wed 09 Oct 2013 01:51:22 PM UTC, comment #2:

I am a bit puzzled - all except one of the changes seemed to be whitespace - is that correct?
I fixed the issue with the return value (should have been void) and used the indent command that has been applied to the code generally. I hope that is ok.

Richard Shann <rshann>
Project Administrator
Wed 09 Oct 2013 12:41:16 PM UTC, comment #1:

I attached a second version of patch (the first one still was missing a "return 0;" statement in importxml.c

(file #29335)

Anonymous
Wed 09 Oct 2013 12:31:59 PM UTC, original submission:

Hello,

this is the usual post-release OBS patch against release tarball 1.0.8, to make the openSUSE build service happy with regard to security issues (rpmlint and additional checks).

Greetings, Edgar

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29335:  denemo-OBS.patch added by None (14KiB - text/x-patch)
file #29334:  denemo-OBS.patch added by None (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rshann (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 Oct 2013 09:06:49 AM UTCrshannOpen/ClosedOpen=>Closed
    Wed 09 Oct 2013 05:15:33 PM UTCrshannStatusNone=>Fixed
    Wed 09 Oct 2013 12:41:16 PM UTCNoneAttached File-=>Added denemo-OBS.patch, #29335
    Wed 09 Oct 2013 12:31:59 PM UTCNoneAttached File-=>Added denemo-OBS.patch, #29334

    Back to the top


    Powered by Savane 3.1-cleanup1