bugGNU Octave - Bugs: bug #40197, get_first_help_sentence fails for...

 
 

bug #40197: get_first_help_sentence fails for multiple @deftypefn

Submitted by:  CarnĂ« Draug <carandraug>
Submitted on:  Mon 07 Oct 2013 08:28:57 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Oct 2013 10:18:21 PM UTC, comment #1:

I fixed it using the changes you suggested. The extra "if" code that was deleted was necessary for the loop above it but not for this second part. See changeset http://hg.savannah.gnu.org/hgweb/octave/rev/7c479b7d3aab.

Rik <rik5>
Project Administrator
Mon 07 Oct 2013 08:28:57 PM UTC, original submission:

Due to recent problems with Texinfo 5, the few functions that need to use the deftypefnx in the middle of the help text must first end the deftypefn (see gallery.m for an example).

The problem is that get_first_help-sentence is not prepared for this and fails with:

A simple fix is to only take the first element by adding (1) at the end of line 128:

Doing this removes those lines but then Texinfo will generate some warnings when calling _makinfo_ (but get_first_help_sentence will work correctly). This can be fixed by removing the following if block:

and only do "keep(end_idx:end)". While doing this solves the problem for my cases, I don't understand the purpose of this condition so I'm not pushing this change. Does anyone have any better idea of what's going on?

This bugs gets triggered when installing a package with such type of help text. The error means that the installation is canceled so the package can't be installed.

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Oct 2013 10:18:21 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1