bugGNU FreeIPMI - Bugs: bug #40076, Does not differentiate between...

 
 

bug #40076: Does not differentiate between different OEM-SEL record types

Submitted by:  Rob Swindell <rswindell>
Submitted on:  Sat 21 Sep 2013 01:40:30 AM UTC  
 
Category: ipmi-selSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Improper Behaviour
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Operating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 23 Sep 2013 04:46:54 PM UTC, comment #2:

How about the attached patch oem_sel_type.new. Following the output of other fields, I output the record type under very verbose output for ipmi-sel. So the output will be like

OEM defined = ...

under normal

OEM defined (record type = ...) = ...

for very verbose.

(file #29203)

Albert Chu <chu11>
Project Administrator
Mon 23 Sep 2013 04:18:03 PM UTC, comment #1:

Sounds like a good idea. Although I think I will slightly change the text. Should be in the next release.

I would love to see contributions to FreeIPMI to be able to parse these OEM records natively :-)

Albert Chu <chu11>
Project Administrator
Sat 21 Sep 2013 01:40:30 AM UTC, original submission:

OEM-SEL entries may have types from 0xC0 through 0xFF, but the ipmi-sel program just output "OEM defined", not differentiating between the different potential OEM-defined record types.

This patch displays the actual 'record type' value for OEM-defined SEL entries. This allows parsers to differentiate between OEM type 0xE0 and 0xE1 for example and interpet the OEM-defined entry data accordingly.

Example ipmi-sel output from before the patch:

3 | N/A | N/A | N/A | N/A | OEM defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

Example ipmi-sel output from after the patch:

3 | N/A | N/A | N/A | N/A | OEM E4h defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

If you prefer to put the record-type in parenthesis or after the word "defined", that would be fine too, but tools which parse OEM-defined entries the output of ipmi-sel will need to know the exact record type value.

Rob Swindell <rswindell>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29203:  oem_sel_type.new added by chu11 (805B - application/octet-stream)
file #29188:  oem_sel_type.patch added by rswindell (571B - text/plain - Patch created with "svn diff" which addresses the issue described.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chu11 (Posted a comment)
  • -unavailable- added by rswindell (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Sep 2013 05:06:37 PM UTCchu11Open/ClosedOpen=>Closed
    Mon 23 Sep 2013 04:46:54 PM UTCchu11Attached File-=>Added oem_sel_type.new, #29203
    Sat 21 Sep 2013 01:40:30 AM UTCrswindellAttached File-=>Added oem_sel_type.patch, #29188

    Back to the top


    Powered by Savane 3.1-cleanup1