bugGNU Octave - Bugs: bug #40041, change to __makeinfo__.m breaks...

 
 

bug #40041: change to __makeinfo__.m breaks generating help for forge packages

Submitted by:  Carlo de Falco <cdf>
Submitted on:  Mon 16 Sep 2013 11:37:13 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Carlo de Falco <cdf>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 16 Sep 2013 03:21:57 PM UTC, comment #1:

I reverted the original changeset and then added a note to the code explaining that the ununesd code can not be deleted until generate_package_html in Octave-Forge is updated (http://hg.savannah.gnu.org/hgweb/octave/rev/cc7815488981).

Rik <rik5>
Project Administrator
Mon 16 Sep 2013 11:37:13 AM UTC, original submission:

This changeset:

removes the third input argument for _makeinfo_
which makes it incompatible with how this function
is used in "generate_package_html".

This problem had occurred before with this changeset:

which was subsequently reverted here:

How can can we fix this in a way that also prevents the problem from happening again?
I see the following alternatives:

1 (easy) - Revert the change and add a comment inside _makeinfo_ to remind that the third argument is indeed used somewhere important.

2 (difficult) - Patch the function html_help_text to work without the third input argument.

3 (unknown difficulty) - move generate_package_html into core so that its existence does not get forgotten.

Which one would be preferred? If no one objects I'll go for the first one later today as it is the least time consuming.

Carlo de Falco <cdf>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by cdf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 16 Sep 2013 03:21:57 PM UTCrik5Open/ClosedOpen=>Closed
    Mon 16 Sep 2013 03:21:56 PM UTCrik5StatusIn Progress=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1