bugGNU Octave - Bugs: bug #39913, Unable to compile...

 
 

bug #39913: Unable to compile __magick_read__.cc after cset ba79ba4e83ab

Submitter:  Rik <rik5>
Submitted:  Sat 31 Aug 2013 10:07:04 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  None Assigned to:  carandraug
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 03 Sep 2013 10:36:42 PM UTC, comment #5: 

ok. Fixed with cset 6e1a3b8fc312

Carnë Draug <carandraug>
Group Member
Tue 03 Sep 2013 10:04:21 PM UTC, comment #4: 

Removing them seems fine since this is just some additional detail in reporting.  imread() works fine for me in loading jpeg-2000 files so the important functionality is already there.

Rik <rik5>
Group administrator
Tue 03 Sep 2013 03:57:10 PM UTC, comment #3: 

Well I'd just remove these from the code then. At the moment they are only used to report the compression method with imfinfo, something that is far from important.

In the future, if someone implements them as compression methods for imwrite, we'd have to actually check them during configure.

Would you agree that removing this is a good solution for this?

Carnë Draug <carandraug>
Group Member
Tue 03 Sep 2013 03:30:10 PM UTC, comment #2: 

Here is the output of "gm version -verbose" which seems to suggest that JPEG-2000 is supported.  I am using the latest long-term release of Kubuntu (12.04) which is mainstream and something Octave should support.


GraphicsMagick 1.3.12 2010-03-08 Q8 http://www.GraphicsMagick.org/
Copyright (C) 2002-2010 GraphicsMagick Group.
Additional copyrights and licenses apply to this software.
See http://www.GraphicsMagick.org/www/Copyright.html for details.

Feature Support:
  Thread Safe              yes
  Large Files (> 32 bit)   yes
  Large Memory (> 32 bit)  yes
  BZIP                     yes
  DPS                      no
  FlashPix                 no
  FreeType                 yes
  Ghostscript (Library)    no
  JBIG                     no
  JPEG-2000                yes
  JPEG                     yes
  Little CMS               yes
  Loadable Modules         yes
  OpenMP                   yes (200805)
  PNG                      yes
  TIFF                     yes
  TRIO                     no
  UMEM                     no
  WMF                      yes
  X11                      yes
  XML                      yes
  ZLIB                     yes


The problem is with 4 enumerated constants.  I wonder if we have to check all 4 or whether we can check just one as an indication for the group.

Rik <rik5>
Group administrator
Sun 01 Sep 2013 06:11:38 PM UTC, comment #1: 

Going through the NEWS file of GraphicsMagick[1], I see that LZMA compression was added in 1.3.13 (released on December 24, 2011). However, I don't see mention of JPEG200 and JBIG in the NEWS. It could be that it was omitted from the NEWS of because it has been there for a very long time but it's disabled in your build of GraphicsMagick.

Can you please check with "gm version -verbose" if it's mentioned support for the formats JBIG and JPEG-2000? Mine reports the following:


Feature Support:
  Thread Safe              yes
  Large Files (> 32 bit)   yes
  Large Memory (> 32 bit)  yes
  BZIP                     yes
  DPS                      no
  FlashPix                 no
  FreeType                 yes
  Ghostscript (Library)    no
  JBIG                     yes
  JPEG-2000                yes
  JPEG                     yes
  Little CMS               yes
  Loadable Modules         no
  OpenMP                   yes (201107)
  PNG                      yes
  TIFF                     yes
  TRIO                     no
  UMEM                     no
  WMF                      yes
  X11                      yes
  XML                      yes
  ZLIB                     yes


If the problem has to do with disabled features, then there will be a lot of ifdefs in _magick_read_.cc

[1] http://www.graphicsmagick.org/NEWS.html

Carnë Draug <carandraug>
Group Member
Sat 31 Aug 2013 10:07:04 PM UTC, original submission:  

Since changeset ba79ba4e83ab (rewrite of iminfo), I am unable to compile Octave.

The errors are listed below.  Apparently these constants are not defined with the version of GraphicsMagick that I have available (1.3.12).  If these constants are going to be used it looks like one of them should be checked for by a macro in configure.ac and then the code in _magick_read_.cc will need an #ifdef around these four constants.


dldfcn/__magick_read__.cc: In function 'octave_value magick_to_octave_value(const MagickLib::CompressionType&)':
dldfcn/__magick_read__.cc:1438:12: error: 'LZMACompression' is not a member of 'Magick'
dldfcn/__magick_read__.cc:1440:12: error: 'JPEG2000Compression' is not a member of 'Magick'
dldfcn/__magick_read__.cc:1442:12: error: 'JBIG1Compression' is not a member of 'Magick'
dldfcn/__magick_read__.cc:1444:12: error: 'JBIG2Compression' is not a member of 'Magick'
make[3]: *** [dldfcn/dldfcn___magick_read___la-__magick_read__.lo] Error 1



Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-03 carandraug Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code