bugGNU Octave - Bugs: bug #39870, Crash when trying to "save...

 
 

bug #39870: Crash when trying to "save file and run" in editor

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Mon 26 Aug 2013 03:03:06 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Segfault, Bus Error, etc.
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 27 Aug 2013 10:01:52 AM UTC, comment #7:

Works OK too here.
Many thanks for fixing, Torsten.

Closing this bug report

Philip Nienhuis <philipnienhuis>
Project Member
Tue 27 Aug 2013 12:43:35 AM UTC, comment #6:

Patch works for me in Windows

John Donoghue <lostbard>
Project Member
Mon 26 Aug 2013 07:33:33 PM UTC, comment #5:

Fixed on Linux (ubuntu) with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/636d75a58cd9
Bug report will be closed when test on Windows is successful.

Torsten <ttl>
Project Member
Mon 26 Aug 2013 06:33:00 PM UTC, comment #4:

Sure; but build only much later tonight & testing at work tomorrow (as that is where I hit it).

BTW I found the actual pop-up texts in the Dutch translation I updated; honestly, until a few minutes ago I had no idea where they belonged. Now I know :-)

Philip Nienhuis <philipnienhuis>
Project Member
Mon 26 Aug 2013 06:15:09 PM UTC, comment #3:

Philip, could you please try the attached patch? I think this issue is a side effect of my cset 17329:352b442a72a5.

(file #28937)

Torsten <ttl>
Project Member
Mon 26 Aug 2013 05:50:36 PM UTC, comment #2:

I'm very sorry, I didn't realize the term "half baked" could ignite so much emotion.
With a "half-baked pop-up" I mean exactly that, literally: a pop-up of which only the borders and main title bar are drawn and the underlying content (of other programs) is still visible in the pop-up's inner parts.

No intention to put of all the work done by you and others. Next time I'll be a lot more careful in choosing my wording.

As to the actual issue:

The actual pop-up message with suggestions or action buttons is never shown, only Octave's diagnosis that the file is not in the load path gets through (in the title bar).

Debugging Qt/C++ code is beyond my expertise, plus from the outside the issue looks like a race condition, therefore I have little hope to successfully investigate this. Staring at code I can vagely follow but not amend properly doesn't help; I'd rather concentrate on the things I can fix like m-files and docs.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 26 Aug 2013 03:14:52 PM UTC, comment #1:

There's really no need to use phrases like "half-baked", eh? You know that this is a work in progress. You've done work on it yourself, so I would expect that you understand that not everything is perfect yet. What do you hope to accomplish by saying things like "half-baked"? It just sounds to me like you are insulting the other people who have worked on the GUI, as if they are too lazy or stupid to make everything perfect before committing any changes.

In any case, isn't it clear that someone intended for Octave to work correctly here by offering to add the directory to the load path or change to the directory? Can you investigate to see why that is not working correctly?

John W. Eaton <jwe>
Project Administrator
Mon 26 Aug 2013 03:03:06 PM UTC, original submission:

(Octave 3.7.6+, MXE build <17330:219552139c18 tip @>, Win7 64 bit)

Steps to reproduce:
1. Load an m-file or script from any subdir outside the load path into the editor, e.g., through "Recent Editor Files" menu.

2. Next, click the blue triangle button "Save file and Run". A half-baked "Change Directory or Add Directory to Load Path" dialog pops up and from then on Octave hangs for ever.
Only way out is the close button, which leads to a "crash" (actually, Windows will terminate Octave the hard way).

The message is clear (first add subdir-to-save-in to load path); but Octave shouldn't hang or crash.

BTW Matlab (r2012a) offers to either change to the subdir in question, or to add it to the load path.
Even better would be if Octave would already emit a suitable warning at the moment that the file is to be read into the editor.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28937:  run_file.patch added by ttl (544B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by ttl (Updated the item)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 27 Aug 2013 10:01:52 AM UTCphilipnienhuisStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 26 Aug 2013 07:33:33 PM UTCttlStatusNone=>Ready For Test
    Mon 26 Aug 2013 06:15:09 PM UTCttlAttached File-=>Added run_file.patch, #28937

    Back to the top


    Powered by Savane 3.1-cleanup1