bugGNU Octave - Bugs: bug #39728, GUI command history incompatible...

 
 

bug #39728: GUI command history incompatible with history_control

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 08 Aug 2013 12:00:01 PM UTC  
 
Category: GUISeverity: 2 - Minor
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 12 Aug 2013 07:21:33 PM UTC, comment #5:

Patch pushed with cset
http://hg.savannah.gnu.org/hgweb/octave/rev/33ce8c381f2c

Torsten <ttl>
Project Member
Sun 11 Aug 2013 04:08:19 PM UTC, comment #4:

Seems fine to me, so please push this change to savannah.

Thanks.

John W. Eaton <jwe>
Project Administrator
Sun 11 Aug 2013 10:32:35 AM UTC, comment #3:

Okay, sorry for my ignorance here.

Another approach (my first but discarded one) would be to add a boolean return value to command_history::add() that is true if something was added to the history. This return value is then used to determine if the octave_link::append_history has to be called (see attached file).

(file #28809)

Torsten <ttl>
Project Member
Sun 11 Aug 2013 01:36:03 AM UTC, comment #2:

I backed out this changeset because nothing from liboctave should ever depend on liboctinterp. For one thing, this will break a build from scratch because liboctinterp will not be built and available for linking with liboctave when liboctave is built.

So we need to find another way to do this job. Perhaps the command_history class can call a user supplied function when adding history? Then the GUI can register a callback function with the command_history class when it starts.

John W. Eaton <jwe>
Project Administrator
Sat 10 Aug 2013 07:26:43 PM UTC, comment #1:

Fixed with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/3d1205d5771e

Torsten <ttl>
Project Member
Thu 08 Aug 2013 12:00:01 PM UTC, original submission:

If history_control is set to "ignorespace", "ignoredups", "ignoreboth", or "erasedups", the GUI command history panel still shows every entry typed in the command window. When Octave exits and restarts, the command history panel shows the correct history. I suppose this is because every command is sent to the GUI on a separate channel from how readline records and saves history. The following example session should show the bug:

Nothing breaks, but it gives the GUI user a false sense of what is in the history if any of the history control bits are set.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28809:  bug39728_v2.patch added by ttl (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 12 Aug 2013 07:21:33 PM UTCttlStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sun 11 Aug 2013 10:32:35 AM UTCttlAttached File-=>Added bug39728_v2.patch, #28809
    Sun 11 Aug 2013 01:36:03 AM UTCjweStatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Sat 10 Aug 2013 07:26:43 PM UTCttlStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1