bugGnash - The GNU Flash player - Bugs: bug #39482, GIFLIB-5.0 API change

 
 

bug #39482: GIFLIB-5.0 API change

Submitted by:  OBATA Akio <obache>
Submitted on:  Sun 14 Jul 2013 02:31:05 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: 0.8.10Status: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 15 Jul 2013 07:24:48 AM UTC, comment #2:

Preprocessor seems to be happy with that macro not being defined, so am I. Patch pushed: http://git.savannah.gnu.org/gitweb/?p=gnash.git;a=commitdiff;h=cc22f2d

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 15 Jul 2013 07:09:32 AM UTC, comment #1:

As of giflib-4.1.6 there's no GIFLIB_MAJOR macro defined in headers.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 14 Jul 2013 02:31:05 AM UTC, original submission:

GIFLIB-5.0 introduce some API change:
http://giflib.sourceforge.net/gif_lib.html#compatibility
It affect to Gnash, so it should be changed.
Following is a proposed patch to resolve the issue.

--- libbase/GnashImageGif.cpp.orig 2012-01-19 19:17:48.000000000 +0000
+++ libbase/GnashImageGif.cpp
@@ -269,7 +269,11 @@ GifInput::processRecord(GifRecordType re
void
GifInput::read()
{
+#if GIFLIB_MAJOR >= 5
+ _gif = DGifOpen(_inStream.get(), &readData, NULL);
+#else
_gif = DGifOpen(_inStream.get(), &readData);
+#endif

GifRecordType record;

OBATA Akio <obache>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by obache (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 15 Jul 2013 07:24:48 AM UTCstrkStatusNone=>Fixed
      Assigned toNone=>strk
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1