bugGNU Octave - Bugs: bug #39262, symbolic package: findsymbols...

 
 

bug #39262: symbolic package: findsymbols should return a cell vector

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Sun 16 Jun 2013 07:42:02 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 18 Jun 2013 04:39:02 PM UTC, comment #3:

Thank you very much. Changeset pushed. See https://sourceforge.net/p/octave/symbolic/ci/d924a90d547f3a10953e43de116f336e15e849b2/

I only made a small ammend to the commit message: mention bug number and the hg changeset rather than just the svn revision being reverted.

Carnë Draug <carandraug>
Project Member
Mon 17 Jun 2013 09:48:01 PM UTC, comment #2:

The Mercurial changeset is attached below.

(file #28338)

Rafael Laboissiere <rlaboiss>
Mon 17 Jun 2013 04:24:54 PM UTC, comment #1:

Thank you for the report. As part of the ongoing move in Octave Forge to use mercurial, I have earlier today converted the symbolic package. It can be found at

https://sourceforge.net/p/octave/symbolic/ci/default/tree/

Do you think you could provide a changeset with the proposed change?

Carnë Draug <carandraug>
Project Member
Sun 16 Jun 2013 07:42:02 PM UTC, original submission:

The Debian package octave-symbolic, since its version 1.1.0-1, has been patched for fixing a problem in function findsymbols, which is expected to return a cell vector. The patch is attached to this bug report.

Thomas Weber brought recently to my attention that this problem was addressed in SVN rev 10688, but I think that the fix is incomplete, since it is only done for findsym, but sym2poly and symfsolve also call findsymbols and have not been fixed.

Please, consider applying my patch and reverting rev 10688.

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28338:  cell-as-retval-in-findsymbols.diff added by rlaboiss (2KiB - text/x-patch - Changeset for the hg repository)
file #28329:  cell-as-retval-in-findsymbols.patch added by rlaboiss (907B - text/x-patch - Patch for src/findsymbols.cc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Jun 2013 04:39:02 PM UTCcarandraugStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 17 Jun 2013 09:48:01 PM UTCrlaboissAttached File-=>Added cell-as-retval-in-findsymbols.diff, #28338
    Sun 16 Jun 2013 07:42:02 PM UTCrlaboissAttached File-=>Added cell-as-retval-in-findsymbols.patch, #28329

    Back to the top


    Powered by Savane 3.1-cleanup1