bugGNU Octave - Bugs: bug #39177, signal package: fir1(8000,0.01)...

 
 

bug #39177: signal package: fir1(8000,0.01) does not work

Submitted by:  None
Submitted on:  Thu 06 Jun 2013 03:17:18 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: MATTOriginator Email: -unavailable-
Open/Closed: ClosedRelease: other
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 23 Jan 2014 06:26:38 AM UTC, comment #3:

This bug has been fixed, the fix will be part of the next signal package release.

http://sf.net/p/octave/signal/ci/58aef1

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 13 Jun 2013 08:42:04 PM UTC, comment #2:

Doesn't look like fir1 has changed substantially between versions, but fir2 has. Here's a comparison between octave-signal_1.1.3 and 1.2.2 in Debian (1.2.0 is quite similar).

[~/Downloads/signal/inst]$ diff fir1.m /usr/share/octave/packages/signal-1.2.2/fir1.m
143,145c143,145
< %!assert(fir1(2, .5, 'low', @hanning, 'scale'), [0 1 0]');
< %!assert(fir1(2, .5, 'low', "hanning", 'scale'), [0 1 0]');
< %!assert(fir1(2, .5, 'low', hanning(3), 'scale'), [0 1 0]');
---

> %!assert(fir1(2, .5, 'low', @hanning, 'scale'), [0 1 0]);
> %!assert(fir1(2, .5, 'low', "hanning", 'scale'), [0 1 0]);
> %!assert(fir1(2, .5, 'low', hanning(3), 'scale'), [0 1 0]);


[~/Downloads/signal/inst]$ diff fir2.m /usr/share/octave/packages/signal-1.2.2/fir2.m | wc -l
89

Furthermore, simple substitution of the old fir2 into a bare directory executes without error. I haven't yet checked that the output is correct. Qualitative checks with my own code and with freqz both suggest that it may be.

[~/octavebug]$ ls
fir2.m
[~/octavebug]$ octave
GNU Octave, version 3.6.4
...
octave:1> size(fir1(10000,0.01))
ans =

10001 1

octave:2>

Charlie Hagedorn <isl>
Thu 06 Jun 2013 06:57:46 PM UTC, comment #1:

Confirmed, fails for any filter order higher than 1023 because of the way it calls fir2.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 06 Jun 2013 03:17:18 PM UTC, original submission:

b = fir1(8000,0.01) returns error message, "error : fir2 : grid size must be greater than half the filter order. "

Using Octave UPM R8.1, the fir1() function in 'Signal' package

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by isl (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 05 Mar 2015 03:06:30 AM UTCmtmillerDependencies-=>bugs #44423 is dependent
    Thu 23 Jan 2014 06:26:38 AM UTCmtmillerOpen/ClosedOpen=>Closed
    Thu 23 Jan 2014 06:26:36 AM UTCmtmillerStatusConfirmed=>Fixed
    Sun 25 Aug 2013 12:07:35 PM UTCmtmillerDependencies-=>bugs #39864 is dependent
    Thu 06 Jun 2013 06:57:46 PM UTCmtmillerStatusNone=>Confirmed
      Assigned toNone=>mtmiller
      Release3.6.4=>other
      Operating SystemMicrosoft Windows=>Any
      Summaryfir1(8000,0.01) does not work =>signal package: fir1(8000,0.01) does not work

    Back to the top


    Powered by Savane 3.1-cleanup1