bugGnash - The GNU Flash player - Bugs: bug #39128, gnash 0.8.10: bad C++ code in...

 
 

bug #39128: gnash 0.8.10: bad C++ code in cygnal/proc.cpp

Submitted by:  David Binderman <dcb314>
Submitted on:  Fri 31 May 2013 04:58:05 PM UTC  
 
Category: cygnalSeverity: 3 - Normal
Release: 0.8.10Status: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 31 May 2013 05:52:03 PM UTC, comment #1:

Good catch! The fix is now committed to master.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Fri 31 May 2013 04:58:05 PM UTC, original submission:

// if (dbglogfile.getVerbosity() > 0) {
cmd_line[1] = new char(3);
strcpy(cmd_line[1], "-n");
cmd_line[2] = new char(4);
strcpy(cmd_line[2], "-vv");
cmd_line[3] = 0;
// }

// When running multiple cgis, we prefer to specify the port it's using.
if (port > 0) {
cmd_line[3] = new char(3);
strcpy(cmd_line[3], "-p");
cmd_line[4] = new char(10);
sprintf(cmd_line[4], "%d", port);
cmd_line[5] = 0;
}

It looks to me like the ( and ) on the calls to new
should be [ and ]. Array new seems to be intended,
but initialisation of one char is actually performed.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 31 May 2013 05:52:03 PM UTCrsavoyeCategoryNone=>cygnal
      ReleaseNone=>0.8.10
      StatusNone=>Fixed
      Assigned toNone=>rsavoye
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1